Skip to content

Fix/license #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptkNktq merged 6 commits into from
Jan 20, 2026
Merged

Fix/license #310

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2eb6695
about-libraries導入
ptkNktq Jan 19, 2026
cd959fe
ライセンス画面更新
ptkNktq Jan 19, 2026
93232b5
不要になったライブラリ削除
ptkNktq Jan 20, 2026
22ca5d8
不要になったライセンス関係のファイル削除
ptkNktq Jan 20, 2026
76355e1
Preview更新
ptkNktq Jan 20, 2026
2331f11
screenshottest更新
ptkNktq Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AndroidApp/.idea/kotlinc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions AndroidApp/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
plugins {
id("common.android")
alias(libs.plugins.about.libraries)
}

android {
Expand All @@ -26,4 +27,5 @@ dependencies {
// その他
implementation(libs.io.insert.koin)
debugImplementation(libs.com.squareup.leakcanary.android)
implementation(libs.about.libraries.core)
}
1 change: 1 addition & 0 deletions AndroidApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ plugins {
alias(libs.plugins.compose.compiler) apply false
alias(libs.plugins.com.google.devtools.ksp) apply false
alias(libs.plugins.com.jaredsburrows.license) apply false
alias(libs.plugins.about.libraries) apply false
}
10 changes: 9 additions & 1 deletion AndroidApp/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ io-insert-koin = "4.1.1"
com-google-code-gson = "2.13.2"
com-squareup-leakcanary = "2.14"
mockk = "1.14.7"
about-libraries = "14.0.0-b01"
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

aboutlibraries mikepenz latest stable version 14.0.0

💡 Result:

Short answer: No — 14.0.0 is not a stable release yet. The latest stable release of AboutLibraries is 13.1.0; 14.0.0 artifacts are published as pre-releases (14.0.0-a*/b*). [1][2][3]

Sources:

  • com.mikepenz artifact listing (shows aboutlibraries latest = 13.1.0). [1]
  • Maven / mvnrepository entry for aboutlibraries-core 13.1.0 (stable, Oct 13, 2025). [2]
  • Gradle Plugin Portal showing 14.0.0 pre-release versions (a01 / b01). [3]

References:
[1] (javadoc.io)
[2] (mvnrepository.com)
[3] (plugins.gradle.org)

Citations:

about-libraries を安定版にアップグレードしてください。

現在使用している 14.0.0-b01 はベータ版です。最新の安定版は 13.1.0 （2025年10月13日リリース）です。本番環境では安定版を使用してください。バージョンを 13.1.0 に更新することをお勧めします。

🤖 Prompt for AI Agents 
In `@AndroidApp/gradle/libs.versions.toml` at line 36, Update the about-libraries
dependency from the beta version to the stable release by changing the toml
entry about-libraries = "14.0.0-b01" to about-libraries = "13.1.0" so the
project uses the recommended stable 13.1.0 release instead of the beta.


[plugins]
com-android-application = { id = "com.android.application", version.ref = "agp" }
Expand All @@ -42,6 +43,7 @@ compose-compiler = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "
com-google-devtools-ksp = { id = "com.google.devtools.ksp", version.ref = "com-google-devtools-ksp" }
com-jaredsburrows-license = { id = "com.jaredsburrows.license", version.ref = "com-jaredsburrows-license" }
screenshot = { id = "com.android.compose.screenshot", version.ref = "androidx-compose-screenshot" }
about-libraries = { id = "com.mikepenz.aboutlibraries.plugin.android", version.ref = "about-libraries" }

[libraries]
# androidx
Expand Down Expand Up @@ -77,10 +79,16 @@ screenshot-validation-api = { group = "com.android.tools.screenshot", name = "sc
android-gradle-plugin = { module = "com.android.tools.build:gradle", version.ref = "agp" }

# その他
com-google-code-gson = { module = "com.google.code.gson:gson", version.ref = "com-google-code-gson" }
# DI
io-insert-koin = { module = "io.insert-koin:koin-android", version.ref = "io-insert-koin" }
io-insert-koin-compose = { module = "io.insert-koin:koin-androidx-compose", version.ref = "io-insert-koin" }
com-google-code-gson = { module = "com.google.code.gson:gson", version.ref = "com-google-code-gson" }
# analyze
com-squareup-leakcanary-android = { module = "com.squareup.leakcanary:leakcanary-android", version.ref = "com-squareup-leakcanary" }
# license
about-libraries-core = { module = "com.mikepenz:aboutlibraries-core", version.ref = "about-libraries" }
about-libraries-compose-core = { module = "com.mikepenz:aboutlibraries-compose-core", version.ref = "about-libraries" }
about-libraries-compose-m3 = { module = "com.mikepenz:aboutlibraries-compose-m3", version.ref = "about-libraries" }

[bundles]
androidx-compose = [
Expand Down
2 changes: 2 additions & 0 deletions AndroidApp/ui/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,6 @@ dependencies {
// その他
implementation(libs.io.insert.koin)
implementation(libs.io.insert.koin.compose)
implementation(libs.about.libraries.compose.core)
implementation(libs.about.libraries.compose.m3)
}
42 changes: 31 additions & 11 deletions ...idApp/ui/src/main/kotlin/me/nya_n/notificationnotifier/ui/screen/license/LicenseScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,56 @@
package me.nya_n.notificationnotifier.ui.screen.license

import android.webkit.WebView
import android.webkit.WebViewClient
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.AlertDialogDefaults
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.SnackbarHostState
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.remember
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.viewinterop.AndroidView
import androidx.compose.ui.unit.dp
import androidx.navigation.NavController
import androidx.navigation.compose.rememberNavController
import com.mikepenz.aboutlibraries.ui.compose.LibraryDefaults
import com.mikepenz.aboutlibraries.ui.compose.android.produceLibraries
import com.mikepenz.aboutlibraries.ui.compose.m3.LibrariesContainer
import com.mikepenz.aboutlibraries.ui.compose.m3.libraryColors
import me.nya_n.notificationnotifier.ui.common.AppScaffold
import me.nya_n.notificationnotifier.ui.theme.AppTheme

@Composable
fun LicenseScreen(navController: NavController) {
val snackbarHostState = remember { SnackbarHostState() }
val libraries by produceLibraries()
AppScaffold(
snackbarHostState = snackbarHostState,
onBack = {
navController.popBackStack()
}
) {
AndroidView(
modifier = Modifier.padding(it),
factory = { context ->
WebView(context).apply {
webViewClient = WebViewClient()
loadUrl("file:///android_asset/open_source_licenses.html")
}
},
LibrariesContainer(
libraries,
Modifier.padding(it),
colors = LibraryDefaults.libraryColors(
libraryBackgroundColor = Color.Transparent,
dialogBackgroundColor = AlertDialogDefaults.containerColor,
dialogConfirmButtonColor = AlertDialogDefaults.textContentColor
),
divider = {
Box(
Modifier
.fillMaxWidth()
.height(1.dp)
.padding(horizontal = 16.dp)
.background(MaterialTheme.colorScheme.secondaryContainer)
)
}
)
}
}
Expand Down