[WRAPPER] Fix UAF for gpgme_data_new_from_cbs reported in #4214 - #4240
Open
zengdage wants to merge 1 commit into
Open
[WRAPPER] Fix UAF for gpgme_data_new_from_cbs reported in #4214#4240zengdage wants to merge 1 commit into
zengdage wants to merge 1 commit into
Conversation
`gpgme_data_release` is invoked without explicitly passing `cbs`. As `cbs` reside inside a union, fetching the `cbs` is a bit complicated, so no cleanup helper is provided. In practice, there are probably few cbs instances, analogous to `cbs->release` that only has five available slots. `gpgme_data_new_from_cbs` in: https://github.com/gpg/gpgme/blob/master/src/data-user.c#L99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpgme_data_releaseis invoked without explicitly passingcbs. Ascbsreside inside a union, fetching thecbsis a bit complicated, so no cleanup helper is provided. In practice, there are probably few cbs instances, analogous tocbs->releasethat only has five available slots.If you think omitting cleanup for
gpgme_data_cbsis not correct way, I can make further changes.gpgme_data_new_from_cbsin:https://github.com/gpg/gpgme/blob/master/src/data-user.c#L99
cbshttps://github.com/gpg/gpgme/blob/master/src/data.h#L135