Fix ogg_sync_pageout hook infinite recursion after 2df07b59#3707
Open
runlevel5 wants to merge 1 commit intoptitSeb:mainfrom
Open
Fix ogg_sync_pageout hook infinite recursion after 2df07b59#3707runlevel5 wants to merge 1 commit intoptitSeb:mainfrom
runlevel5 wants to merge 1 commit intoptitSeb:mainfrom
Conversation
The commit 2df07b5 has caused regression
Owner
|
Thanks for the issue, but this is absolutly not a fix. The issue is infinite loops in memory allocators, and you create a workaround for a single ogg call? what about all the other call that also use memory? |
Owner
|
I'll push something more generic, as it can also happens with all hooked symbols from mallochook.c |
ptitSeb
added a commit
that referenced
this pull request
Mar 25, 2026
…tion, like mallochook does (alternative to #3707)
Owner
|
I have pushed this be199c5 that should fix your issue with ogg and all the potnetial others with mallochook |
Owner
|
Mmmm, I don't think this, or anything else, will work with the new alt handling, as the dynarec will always shadow the address. I might need to think of something more there. Maybe forcing the 1st step as interpreter? |
ptitSeb
added a commit
that referenced
this pull request
Mar 25, 2026
…lt is used, to avoid inifite alt redirection (for #3707)
Owner
|
I will probably work on a better solution latter, to avoid this passage via the Interpreter... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ogg_sync_pageouthook caused by commit 2df07b5 ([DYNAREC] Refactored how Alt are undled with Dynarec)suppressAlternate/unsuppressAlternateAPI to temporarily bypass alternate resolution for a specific addressI have tested it on PPC64LE, but love to get help from other backend contributors to see my changes would cause any issue