Make RequestsCookieJar.popitem() work#7513
Open
vineethsaivs wants to merge 1 commit into
Open
Conversation
RequestsCookieJar subclasses both CookieJar and MutableMapping. Its __iter__ comes from CookieJar and yields Cookie objects rather than names, so the popitem() inherited from MutableMapping did `self[next(iter(self))]`, i.e. looked a cookie up by a Cookie object, and always raised KeyError even when the jar was non-empty. Override popitem() to remove and return a (name, value) pair using the jar's dict-like view, and raise KeyError only when the jar is empty, matching the documented behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6190
RequestsCookieJarsubclasses bothCookieJarandMutableMapping[str, str | None]. Its__iter__is inherited fromCookieJarand yieldsCookieobjects rather than names. Thepopitem()it inherited fromMutableMappingdoes roughly:so
popitem()always raisedKeyError, even on a non-empty jar:This overrides
popitem()to remove and return a(name, value)pair using the jar's existing dict-like view (iteritems()), and to raiseKeyErroronly when the jar is empty, matching the documented behavior and theMutableMapping[str, str | None]contract.Added a regression test (
test_cookie_popitem) that pops both entries, checks each returned pair is a real(name, value)from the jar, and confirms aKeyErroron the empty jar. It fails onmainand passes with this change.