Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

Update dependencies and remove obsolete rules_proto reference

@google-cla
Copy link

google-cla bot commented Oct 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mmorel-35 mmorel-35 marked this pull request as ready for review October 3, 2025 10:26
Copy link
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mmorel-35 mmorel-35 requested a review from mpwarres December 4, 2025 07:03
@mmorel-35
Copy link
Contributor Author

Friendly ping 👋🏻

Copy link
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry--approved, now looking into the runners.

@mmorel-35
Copy link
Contributor Author

What is blocking the workflows here ?

@PiotrSikora
Copy link
Member

Might be Google GitHub Admin: Actions Workflow Security Scan that I think was added your last update?

Force-push should re-kick the CI.

@mmorel-35
Copy link
Contributor Author

What do you mean?
Workflows hasn't changed in 11 months in the project?

@PiotrSikora
Copy link
Member

I think Google GitHub Admin: Actions Workflow Security Scan was added at the organization level, since I only noticed it recently in all projects in proxy-wasm org.

Just force-push to re-kick, and someone from Google can investigate if that doesn't help.

@mmorel-35
Copy link
Contributor Author

It looks like a mandatory job defined at proxy-wasm level but the job does not exists here

@PiotrSikora
Copy link
Member

Right, but if you force-push (git commit --amend && git push -f mmorel-35 rules_proto:rules_proto or similar), then it might (should?) re-kick the CI with the new workflow.

@mmorel-35 mmorel-35 force-pushed the rules_proto branch 3 times, most recently from de5ba40 to 9721176 Compare January 22, 2026 18:10
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

That's indeed better!

@leonm1 leonm1 merged commit 894dd29 into proxy-wasm:main Jan 23, 2026
5 checks passed
@mmorel-35 mmorel-35 deleted the rules_proto branch January 23, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants