fix(oci): pass provider UID to update credentials forms by andoniaf · Pull Request #9746 · prowler-cloud/prowler

andoniaf · 2026-01-09T09:43:34Z

Summary

Fix OCI update credentials form failing silently due to missing provider UID
The update credentials flow was missing the providerUid prop required for OCI form validation
The OCI tenancy field is a hidden field auto-populated from provider UID, but was empty causing validation to fail

Changes

Fetch provider data in update-credentials/page.tsx to get the UID (matching existing behavior in add-credentials/page.tsx)
Pass providerUid prop to UpdateViaCredentialsForm, UpdateViaRoleForm, and UpdateViaServiceAccountForm

Test plan

Navigate to update credentials for an OCI provider
Fill in the credential fields
Verify the "Next" button works and progresses to the next step

Checklist

Are there new checks included in this PR? Yes / No
- If so, do we need to update permissions for the provider? Please review this carefully.
Review if the code is being covered by tests.
Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
Review if backport is needed.
Review if is needed to change the Readme.md
Ensure new entries are added to CHANGELOG.md, if applicable.

UI

All issue/task requirements work as expected on the UI
Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
Ensure new entries are added to CHANGELOG.md, if applicable.

API

Verify if API specs need to be regenerated.
Check if version updates are required (e.g., specs, Poetry, etc.).
Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The update credentials flow was missing the provider UID that is required for OCI form validation. The OCI tenancy field is a hidden field that gets auto-populated from the provider UID, but it was empty in the update flow causing form validation to fail silently. Changes: - Fetch provider data in update-credentials page to get the UID - Pass providerUid prop to UpdateViaCredentialsForm - Pass providerUid prop to UpdateViaRoleForm - Pass providerUid prop to UpdateViaServiceAccountForm

github-actions · 2026-01-09T09:43:53Z

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

github-actions · 2026-01-09T09:43:54Z

✅ Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

github-actions · 2026-01-09T09:51:22Z

🔒 Container Security Scan

Image: prowler-ui:e8b7c49
Last scan: 2026-01-15 09:17:04 UTC

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

📋 Resources:

Download full report (see artifacts)
View in Security tab
Scanned with Trivy

alejandrobailo

Thanks @andoniaf , few things to improve

Before Merge:

1. Add error handling for getProvider failure (critical)
2. Add E2E test for OCI update flow with UID validation
3. Consider validation for missing/invalid providerId

Nice to Have:
- Extract FormData creation pattern to helper if used elsewhere

…-update-credentials-missing-uid

Address PR review comments: - Add error handling for getProvider failure (redirect to /providers) - Add validation for missing providerId (redirect to /providers) - Add E2E test for OCI update credentials flow (@PROVIDER-E2E-013) - Add page object methods for update credentials interactions - Document new test case in providers.md

Fix E2E test failure where clickProviderRowActions was matching 2 elements (copy button and dropdown trigger). Use aria-haspopup="true" attribute to specifically target the dropdown trigger button.

HeroUI uses aria-haspopup="menu" not aria-haspopup="true" for dropdown triggers. Fix the selector in clickProviderRowActions to match correctly.

- Use row.locator("button").last() for dropdown trigger selector - Add stabilization wait and force click for dropdown menu items - Add verifyOCIUpdateCredentialsPageLoaded for update flow (Tenancy OCID hidden) - Add verifyTestConnectionPageLoaded for update flow navigation - Fix clickNext to exclude Next.js dev tools button with exact match

andoniaf · 2026-01-15T09:34:59Z

Thanks @andoniaf , few things to improve

Before Merge:
1. Add error handling for getProvider failure (critical)
2. Add E2E test for OCI update flow with UID validation
3. Consider validation for missing/invalid providerId
Nice to Have: - Extract FormData creation pattern to helper if used elsewhere

Thanks @alejandrobailo, "Before Merge" all done:

Error handling for getProvider failure ✅
- Added redirect to /providers when getProvider returns errors (following the pattern from test-connection/page.tsx)
E2E test for OCI update flow with UID validation ✅
- Added @PROVIDER-E2E-013 test that:
- Navigates to providers page
- Finds existing OCI provider
- Opens update credentials flow
- Verifies form loads correctly (provider UID populated)
- Submits updated credentials
- Verifies navigation to test-connection page
Validation for missing/invalid providerId ✅
- Added redirect to /providers when providerId is missing (required for update flow)

alejandrobailo

Thanks, nice work!

prowler-bot · 2026-01-15T10:30:23Z

💚 All backports created successfully

Status	Branch	Result
✅	v5.16

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

…d#9746)

andoniaf requested a review from a team as a code owner January 9, 2026 09:43

github-actions Bot added the component/ui label Jan 9, 2026

andoniaf changed the title ~~fix(ui): pass provider UID to update credentials forms~~ fix(oci): pass provider UID to update credentials forms Jan 9, 2026

docs(ui): add changelog entry for OCI update credentials fix

87d31f2

jfagoagas added the backport-to-v5.16 Backport PR to the v5.16 branch label Jan 9, 2026

alejandrobailo requested changes Jan 14, 2026

View reviewed changes

andoniaf added 5 commits January 14, 2026 17:31

Merge remote-tracking branch 'origin/master' into PROWLER-659/fix-oci…

7fe6935

…-update-credentials-missing-uid

fix(ui): use aria-haspopup selector for provider row actions button

0684b72

Fix E2E test failure where clickProviderRowActions was matching 2 elements (copy button and dropdown trigger). Use aria-haspopup="true" attribute to specifically target the dropdown trigger button.

fix(ui): use correct aria-haspopup value for dropdown selector

a83c7ab

HeroUI uses aria-haspopup="menu" not aria-haspopup="true" for dropdown triggers. Fix the selector in clickProviderRowActions to match correctly.

andoniaf requested a review from alejandrobailo January 15, 2026 09:35

alejandrobailo approved these changes Jan 15, 2026

View reviewed changes

andoniaf merged commit 28978f6 into master Jan 15, 2026
36 of 38 checks passed

andoniaf deleted the PROWLER-659/fix-oci-update-credentials-missing-uid branch January 15, 2026 10:29

prowler-bot mentioned this pull request Jan 15, 2026

fix(oci): pass provider UID to update credentials forms #9799

Merged

prowler-bot added the was-backported The PR was successfully backported to the target branch label Jan 15, 2026

Alan-TheGentleman pushed a commit that referenced this pull request Jan 15, 2026

fix(oci): pass provider UID to update credentials forms (#9746)

76d65dd

Hamza-abughazaleh pushed a commit to Raed-sh/prowler that referenced this pull request Feb 11, 2026

fix(oci): pass provider UID to update credentials forms (prowler-clou…

06d055b

…d#9746)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(oci): pass provider UID to update credentials forms#9746

fix(oci): pass provider UID to update credentials forms#9746
andoniaf merged 7 commits intomasterfrom
PROWLER-659/fix-oci-update-credentials-missing-uid

andoniaf commented Jan 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

alejandrobailo left a comment

Uh oh!

andoniaf commented Jan 15, 2026

Uh oh!

alejandrobailo left a comment

Uh oh!

Uh oh!

prowler-bot commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

andoniaf commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Checklist

UI

API

License

Uh oh!

github-actions Bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔒 Container Security Scan

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

Uh oh!

alejandrobailo left a comment

Choose a reason for hiding this comment

Uh oh!

andoniaf commented Jan 15, 2026

Uh oh!

alejandrobailo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prowler-bot commented Jan 15, 2026

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andoniaf commented Jan 9, 2026 •

edited

Loading

github-actions Bot commented Jan 9, 2026 •

edited

Loading

github-actions Bot commented Jan 9, 2026 •

edited

Loading

github-actions Bot commented Jan 9, 2026 •

edited

Loading