fix: drop legacy-only place names#582
Open
tijptjik wants to merge 1 commit into
Open
Conversation
Member
|
It is not clear what part of the project you are referring to, can you provide a link to a map view on https://pmtiles.io with one of the basemap tiles builds showing where these places without The screenshots you're showing are of a different map style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current processing doesn't handle cases where a point only has
old_namekeys and nonamekey which is sometimes used to indicate places which no longer exist.Example from Hong Kong
Napier's Range only has
old tags. With this fix, these points are filtered and the map only renders current names