ci: pin contents: read on the CI workflow#824
Merged
Conversation
Standard prometheus/promci pipeline. Docker Hub + Quay pushes (and any release artifacts) use their own dedicated secrets; the default GITHUB_TOKEN only needs read for the checkout. Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
f2a8873 to
69e1ac9
Compare
Contributor
Author
|
Hi @jan--f, gentle ping on this. The PR has been open for 4 days without a review. I noticed you've been on the recent-merger side of recent merges in this repo, so I thought I'd reach out. When you have a moment, would you mind giving this a quick look? No urgency, just trying to keep it on the radar. Happy to address any feedback. |
Contributor
Author
|
Hi, Following up on this since it's been a couple weeks. Happy to rebase or pare scope if useful. Appreciated. |
jan--f
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENto read-only forci.yml. Image push (Docker Hub / Quay) and release publication use their own dedicated secrets (docker_hub_login/docker_hub_password,quay_io_login/quay_io_password, and the prom-bot PAT for releases), so the default token only needs read access for the checkout. Matches the top-level pattern in the other prometheus repos.