Add device filtering to the infiniband collector#3694
Open
yugstar wants to merge 1 commit into
Open
Conversation
Add --collector.infiniband.device-include and --collector.infiniband.device-exclude flags to the infiniband collector, following the existing pattern used by the arp, ethtool, diskstats and netdev collectors. Devices not matching the filter are skipped in Update. Signed-off-by: Aman Raj <aman.yug@gmail.com>
yugstar
force-pushed
the
feat-3583-infiniband-device-filter
branch
from
bb52684 to
2d00d08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3583
Adds
--collector.infiniband.device-includeand--collector.infiniband.device-excludeflags to the infiniband collector, so operators can scrape a subset of infiniband devices.This follows the established
deviceFilterpattern already used by the arp, ethtool, diskstats and netdev collectors: two mutually-exclusive include/exclude regexp flags, adeviceFilterfield on the collector, and ac.deviceFilter.ignored(device.Name)skip at the top of theUpdatedevice loop. The filter logic itself is covered bycollector/device_filter_test.go.Defaults are unchanged — with neither flag set, all devices are scraped as before.
Verified:
GOOS=linux go build/vet ./collector/and the collector test binary compile cleanly; gofmt clean; DCO signed.