Skip to content

fix(om2): consistency between model and exposition #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krajorama wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix(om2): consistency between model and exposition #2890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c3a8c3
fix(om2): consistency between model and exposition
krajorama Mar 12, 2026
49fa6e9
Merge branch 'main' into krajo/om2-should-meta
krajorama Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/specs/om/open_metrics_spec_2_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ If more than one MetricPoint is exposed for a Metric, then its MetricPoints MUST

#### MetricFamily

A MetricFamily MAY have zero or more Metrics. A MetricFamily MUST have a name, HELP, TYPE, and UNIT metadata. Every Metric within a MetricFamily MUST have a unique LabelSet.
A MetricFamily MAY have zero or more Metrics. Every Metric within a MetricFamily MUST have a unique LabelSet. A MetricFamily SHOULD have a name, Help, Type, and Unit metadata.
Copy link
Contributor

@dashpole dashpole Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well... You do definitely need a name, so we should probably keep that as a must


##### Name

Expand Down
Loading