Open
Conversation
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
6562eaf to
ec60b58
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds experimental OpenMetrics 2.0 configuration plumbing to the prometheus-metrics-config module so OM2 feature flags can be set via builder APIs and loaded from properties/env vars (as part of #1912).
Changes:
- Introduce
OpenMetrics2Propertieswith OM2 feature-flag fields, builder, and property loading. - Wire OM2 properties into
PrometheusPropertiesandPrometheusPropertiesLoader. - Add/extend unit tests covering defaults, builder usage, enable-all, and property loading/error handling.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| prometheus-metrics-config/src/main/java/io/prometheus/metrics/config/PrometheusPropertiesLoader.java | Loads OpenMetrics2Properties and includes it in the assembled PrometheusProperties. |
| prometheus-metrics-config/src/main/java/io/prometheus/metrics/config/PrometheusProperties.java | Adds openMetrics2Properties field + getter and builder APIs (enableOpenMetrics2, direct assignment). |
| prometheus-metrics-config/src/main/java/io/prometheus/metrics/config/OpenMetrics2Properties.java | New OM2 flag container with property parsing and builder (including enableAll()). |
| prometheus-metrics-config/src/test/java/io/prometheus/metrics/config/PrometheusPropertiesTest.java | Adds tests for OM2 builder patterns, defaults, and loading via PrometheusPropertiesLoader. |
| prometheus-metrics-config/src/test/java/io/prometheus/metrics/config/OpenMetrics2PropertiesTest.java | New tests for OM2 property loading, invalid values, builder behavior, and defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1912