fix: use promtool for listenLocal health probes#8672
Open
SebTardif wants to merge 2 commits into
Open
Conversation
Distroless Prometheus images lack sh/curl/wget, so exec probes built with a shell wrapper always fail when listenLocal is true. Probe with promtool check healthy/ready against localhost instead. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
heliapb
reviewed
Jul 6, 2026
Comment on lines
+33
to
+35
| baseURL := u | ||
| if i := strings.Index(u, "/-/"); i >= 0 { | ||
| baseURL = u[:i] |
Member
There was a problem hiding this comment.
Hi @SebTardif as the ci issue notes this can be changed as
Suggested change
| baseURL := u | |
| if i := strings.Index(u, "/-/"); i >= 0 { | |
| baseURL = u[:i] | |
| baseURL, _, _ := strings.Cut(u, "/-/") |
Contributor
Author
There was a problem hiding this comment.
Done in 05c75f1 — switched to strings.Cut as suggested.
Satisfy modernize/stringscut (golangci-lint) as noted in review. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
listenLocal: true, probes usedsh -cwithcurl/wget. Distroless images (default in kube-prometheus-stack) do not include those tools, so readiness/liveness fail permanently.Fix
Use
promtool check healthy|ready --url=http://localhost:9090for listenLocal probes.promtoolships in official Prometheus images.Testing
go test ./pkg/operator/ -run TestProbersstatefulset_test.goRef #8605