Replace placeholder image in custom KServe predictor manifest#49
Open
Replace placeholder image in custom KServe predictor manifest#49
Conversation
Build the minimal-custom-kserve-predictor image, push it to the prokube registry, and replace the <YOUR IMAGE> placeholder in inference-service.yaml with the actual image path (with a REPLACE ME comment for external users). Also add a GitLab CI job to keep the image up to date on changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<YOUR IMAGE>placeholder inserving/minimal-custom-kserve-predictor/inference-service.yamlwith the actual prokube registry image, adding a# REPLACE MEcomment for users without registry accesseurope-west3-docker.pkg.dev/prokube-internal/prokube-customer/minimal-custom-kserve-predictor:latestminimal-custom-kserve-predictor-build) to keep the image up to date on changes to that directory, consistent with existing CI jobs for other imagesCloses https://github.com/prokube/dev-tracker/issues/96