Skip to content

fix: remove value from atrule nodes, fix MediaType/MediaFeature accessors#171

Merged
bartveneman merged 4 commits intomainfrom
fix/no-atrule-value
Mar 11, 2026
Merged

fix: remove value from atrule nodes, fix MediaType/MediaFeature accessors#171
bartveneman merged 4 commits intomainfrom
fix/no-atrule-value

Conversation

@bartveneman
Copy link
Member

atrule.value: 'screen' -> undefined (use atrule.prelude instead)
mediaType.value: null -> 'screen'
mediaFeature.name: 'min-width' -> undefined (use mediaFeature.property instead)

  • Stop setting value offsets on AT_RULE nodes in parse.ts; the prelude is now fully represented by child nodes (AT_RULE_PRELUDE or RAW)
  • atrule.value returns undefined; atrule.prelude is the correct API
  • mediaType.value returns the node text (e.g. "screen", "print")
  • mediaFeature.name returns undefined; use mediaFeature.property instead
  • has_prelude for AT_RULE now checks first_child type instead of value length

bartveneman and others added 2 commits March 11, 2026 10:16
…sors

atrule.value: 'screen' -> undefined (use atrule.prelude instead)
mediaType.value: null -> 'screen'
mediaFeature.name: 'min-width' -> undefined (use mediaFeature.property instead)

- Stop setting value offsets on AT_RULE nodes in parse.ts; the prelude
  is now fully represented by child nodes (AT_RULE_PRELUDE or RAW)
- atrule.value returns undefined; atrule.prelude is the correct API
- mediaType.value returns the node text (e.g. "screen", "print")
- mediaFeature.name returns undefined; use mediaFeature.property instead
- has_prelude for AT_RULE now checks first_child type instead of value length

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (d92b016) to head (5842de6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          16       16           
  Lines        2876     2877    +1     
  Branches      804      807    +3     
=======================================
+ Hits         2732     2733    +1     
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2026

Bundle Report

Changes will decrease total bundle size by 62 bytes (-0.04%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@projectwallace/css-parser-esm 159.03kB -62 bytes (-0.04%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: @projectwallace/css-parser-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
css-node-Uj4oBgaw.js (New) 20.82kB 20.82kB 100.0% 🚀
parse.js -155 bytes 10.04kB -1.52%
css-node-2ejJUrIw.js (Deleted) -20.73kB 0 bytes -100.0% 🗑️

Files in css-node-Uj4oBgaw.js:

  • ./src/css-node.ts → Total Size: 12.46kB

Files in parse.js:

  • ./src/parse.ts → Total Size: 9.64kB

@bartveneman bartveneman merged commit 79f1c7a into main Mar 11, 2026
4 checks passed
@bartveneman bartveneman deleted the fix/no-atrule-value branch March 11, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants