Skip to content

Set metadata.namespace for alert-routing-discovery debug configmap - #121

Merged
simu merged 1 commit into
masterfrom
fix/addon-alert-routing-discovery-debug-cm
Aug 6, 2026
Merged

Set metadata.namespace for alert-routing-discovery debug configmap#121
simu merged 1 commit into
masterfrom
fix/addon-alert-routing-discovery-debug-cm

Conversation

@simu

@simu simu commented Aug 6, 2026

Copy link
Copy Markdown
Member

Fixes #119

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@simu simu added bug Something isn't working bump:patch labels Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🚀 This PR has been released as v2.16.1

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:patch

@simu
simu requested a review from a team August 6, 2026 14:18
@simu
simu marked this pull request as ready for review August 6, 2026 14:18
@simu
simu requested a review from a team as a code owner August 6, 2026 14:18

@HappyTetrahedron HappyTetrahedron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tested against my mako test cluster and it rendered the expected namespace:

metadata:
  annotations:
    source: https://github.com/projectsyn/component-prometheus
  labels:
    app.kubernetes.io/managed-by: commodore
    app.kubernetes.io/part-of: syn
  name: alert-routing-discovery-debug
  namespace: syn-monitoring

@simu
simu merged commit e298916 into master Aug 6, 2026
54 checks passed
@simu
simu deleted the fix/addon-alert-routing-discovery-debug-cm branch August 6, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working bump:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants