fix: -pr http11 flag is ignored on retryablehttp-go due to HTTP/2 fall#2419
Open
SolariSystems wants to merge 1 commit intoprojectdiscovery:devfrom
Open
fix: -pr http11 flag is ignored on retryablehttp-go due to HTTP/2 fall#2419SolariSystems wants to merge 1 commit intoprojectdiscovery:devfrom
SolariSystems wants to merge 1 commit intoprojectdiscovery:devfrom
Conversation
…lback Addresses projectdiscovery#2240 Signed-off-by: Mark Brush <solarisys2025@gmail.com>
Neo - PR Security ReviewNo security issues found Highlights
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2240
Changes Made
Clean, minimal, and correct fix. The 3-line option change properly threads the HTTP/1.1 preference into retryablehttp-go's existing DisableHTTP2Fallback guard (verified at do.go:63 and client.go:119), the string-literal-to-constant cleanup is a welcome bonus, and the two unit tests directly verify the structural invariant that makes the fix work.
Verification