Skip to content

chore: remove unused dracut config#381

Open
renner0e wants to merge 1 commit into
mainfrom
remove-dracut-conf
Open

chore: remove unused dracut config#381
renner0e wants to merge 1 commit into
mainfrom
remove-dracut-conf

Conversation

@renner0e
Copy link
Copy Markdown
Contributor

@renner0e renner0e commented May 31, 2026

This is not even in the proper directory to work with dracut, this config file should also not be here, this should not be shared between any image variants and should be on the repo of the image itself.

Not every image uses dracut. We seem to have missed this when introducing this here into this repo.

Summary by CodeRabbit

  • Chores
    • Updated dracut configuration to remove FIDO2, TPM2-TSS, PKCS11, and PCSC module inclusions from the boot initialization process.

This is not even in the proper directory to work with dracut, this
config file should also not be here, this should not be shared between
any image variants and should be on the repo of the image itself.

Not every image uses dracut. We seem to have missed this when
introducing this here into this repo.
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. kind/tech-debt Bluefin needs to eat her vegetables too labels May 31, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dac994f6-ea86-45a2-a33f-33c8545b0410

📥 Commits

Reviewing files that changed from the base of the PR and between b132745 and d3b3a25.

📒 Files selected for processing (1)
  • system_files/shared/usr/lib/dracut/fido-tpm2-luks.conf
💤 Files with no reviewable changes (1)
  • system_files/shared/usr/lib/dracut/fido-tpm2-luks.conf

📝 Walkthrough

Walkthrough

The dracut configuration file removes a line that previously appended FIDO2, TPM2-TSS, PKCS11, and PCSC modules to the add_dracutmodules variable.

Changes

Dracut Module Configuration

Layer / File(s) Summary
Remove dracut modules from configuration
system_files/shared/usr/lib/dracut/fido-tpm2-luks.conf
A line appending fido2 tpm2-tss pkcs11 pcsc to add_dracutmodules is removed from the dracut configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through configs bright,
Modules fade from distant sight,
FIDO, TPM, and PKCS too,
Cleaner dracut, fresh and new! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove unused dracut config' accurately describes the main change—removing an unused dracut configuration file.
Description check ✅ Passed The description provides clear context about why the dracut config is being removed and explains the architectural reasoning, though it lacks explicit section structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-dracut-conf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 31, 2026
@inffy inffy enabled auto-merge May 31, 2026 03:54
@inffy inffy disabled auto-merge May 31, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/tech-debt Bluefin needs to eat her vegetables too lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants