feat(just): add check-sb-key recipe for Secure Boot status#370
Conversation
Adds a ujust check-sb-key command that reports: - Secure Boot enable/disable state (via mokutil or EFI vars) - Machine Owner Key (MOK) enrollment status - Kernel signature verification (sbverify fallback) Closes #13
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughNew ChangesSecure Boot Status Check Recipe
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@system_files/bluefin/usr/share/ublue-os/just/system.just`:
- Around line 127-132: The current code runs inside the if command -v sbverify
check so the fallback message "sbverify not available (install sbsigntools)" is
misleading when sbverify --list /boot/vmlinuz-$(uname -r) fails; update the
failure branch so it reports that sbverify could not list signatures for
/boot/vmlinuz-$(uname -r) (mention possible causes like missing kernel file or
permission issues) and include the actual sbverify stderr/output instead of
suggesting installation; locate the block using the command -v sbverify check
and the sbverify --list invocation to implement this clearer error message and
surface the real error details.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5710312f-1005-4afe-8b5e-0b46e9578bc9
📒 Files selected for processing (1)
system_files/bluefin/usr/share/ublue-os/just/system.just
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Adds a ujust check-sb-key command that reports Secure Boot status, MOK enrollment, and kernel signature verification.
Closes #13
Summary by CodeRabbit