Skip to content

feat(ujust): wire flutter devcontainer recipe import#356

Open
castrojo wants to merge 1 commit into
projectbluefin:mainfrom
castrojo:upstream-pr/flutter-devcontainer
Open

feat(ujust): wire flutter devcontainer recipe import#356
castrojo wants to merge 1 commit into
projectbluefin:mainfrom
castrojo:upstream-pr/flutter-devcontainer

Conversation

@castrojo
Copy link
Copy Markdown
Contributor

@castrojo castrojo commented May 29, 2026

This adds the scaffolding for the antigravity/flutter just. I am testing that live on dakota before PRing it here but this can land now.

Agent Notes:

Adds an optional import for flutter.just so that Dakota systems shipping /usr/share/ublue-os/just/flutter.just automatically expose ujust install-flutter to end users.

Uses import? so non-Dakota Bluefin variants are unaffected.

Assisted-by: Claude via pi

Summary by CodeRabbit

  • Chores
    • Added conditional support for Flutter-related build tasks, making Flutter functionality available within the system's build and configuration framework.

Review Change Stack

Refs #356common

Adds an optional import for flutter.just so that Dakota systems
shipping /usr/share/ublue-os/just/flutter.just automatically expose
`ujust install-flutter` to end users.

Uses import? so non-Dakota Bluefin variants are unaffected.

Assisted-by: Claude via pi
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area/just Justfile things kind/enhancement New feature, don't implement without a spec and consensus labels May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

📝 Walkthrough

Walkthrough

This PR adds a single optional import line for flutter.just to the entry point justfile configuration, positioning it in the conditional imports section between the required update.just and optional custom.just imports. No other logic or files are modified.

Changes

Flutter Integration

Layer / File(s) Summary
Optional Flutter.just import
system_files/bluefin/usr/share/ublue-os/just/00-entry.just
Adds import? "/usr/share/ublue-os/just/flutter.just" as an optional import in the entry point justfile, positioned between update.just and custom.just imports.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A flutter of wings, so light and bright,
One line added to make things right,
The build system now spreads its wings—
Flutter tasks among the things! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(ujust): wire flutter devcontainer recipe import' accurately describes the main change: adding an optional import for flutter.just to the ujust entry point file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly explains the purpose, implementation details, and testing status. It follows the repository template guidance by placing changes in the Bluefin folder and notes relevant considerations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 29, 2026
@castrojo castrojo enabled auto-merge May 30, 2026 04:33
@castrojo
Copy link
Copy Markdown
Contributor Author

🤖 Copilot Test Report

Branch: upstream-pr/flutter-devcontainer | 6 commits behind main | Tested: 2026-05-30T04:51Z

Test Results

Test Result
just check (syntax validation) ✅ PASS
Branch freshness ✅ Near head

Notes

Wires Flutter devcontainer recipe import to apps.just. Straightforward import line addition.

@castrojo
Copy link
Copy Markdown
Contributor Author

🔔 Needs 2 approvals from maintainers to enter the merge queue (can't self-approve). Both conflict issues have been resolved via rebase — branch is clean and just check passes.

@castrojo castrojo closed this May 30, 2026
auto-merge was automatically disabled May 30, 2026 07:38

Pull request was closed

@castrojo castrojo reopened this May 30, 2026
@castrojo castrojo closed this May 30, 2026
@castrojo castrojo reopened this May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/just Justfile things kind/enhancement New feature, don't implement without a spec and consensus lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants