Skip to content

fix: remove Readymade installer from dock favorite-apps#353

Open
hanthor wants to merge 2 commits into
mainfrom
fix/remove-installer-from-dock-213
Open

fix: remove Readymade installer from dock favorite-apps#353
hanthor wants to merge 2 commits into
mainfrom
fix/remove-installer-from-dock-213

Conversation

@hanthor
Copy link
Copy Markdown
Member

@hanthor hanthor commented May 29, 2026

Summary

Removes com.fyralabs.Readymade.desktop from the GNOME dock favorite-apps list.

The installer has a noticeable startup delay, so users who see the dock icon during first boot keep clicking it thinking it did not launch, resulting in duplicate installer windows. The installer auto-launches via its own mechanism and remains accessible from the app menu — the dock pin is purely redundant noise.

Closes #213

Test plan

  • Fresh install: installer still launches automatically on first boot
  • Installer is accessible from the app menu (not in the dock)
  • Dock shows: Firefox, Thunderbird, Files, Bazaar, Software, VS Code

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed an application from the system favorites list in GNOME Shell configuration.

Review Change Stack

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c8ae33e7-695d-4b6a-9f39-ac306fa798bf

📥 Commits

Reviewing files that changed from the base of the PR and between 843d8a4 and 11a789c.

📒 Files selected for processing (1)
  • system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override

📝 Walkthrough

Walkthrough

This PR removes the Readymade installation icon (com.fyralabs.Readymade.desktop) from GNOME Shell's dock favorite-apps list in the Bluefin schema override configuration file. The change affects only the favorites array under [org.gnome.shell].

Changes

GNOME Shell dock configuration

Layer / File(s) Summary
Favorite apps configuration update
system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override
The org.gnome.shell favorite-apps array is updated to remove com.fyralabs.Readymade.desktop, eliminating the installation icon from the dock while preserving all other pinned applications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 One icon departs from the dock so bright,
No more installation delays in sight,
The menu still holds what users may seek,
While autolaunch handles the task so sleek! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing the Readymade installer from the dock's favorite-apps list.
Description check ✅ Passed The description provides a clear summary, rationale, linked issue reference, and test plan. It meets the template expectations for Bluefin-related GNOME changes.
Linked Issues check ✅ Passed The PR fully addresses issue #213 by removing com.fyralabs.Readymade.desktop from the dock favorite-apps, eliminating the redundant installer icon while maintaining auto-launch and menu accessibility.
Out of Scope Changes check ✅ Passed All changes are scoped to removing the Readymade installer entry from the gschema override file, directly addressing the linked issue with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-installer-from-dock-213

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added area/gnome Anything GNOME related kind/bug Something isn't working labels May 29, 2026
Copy link
Copy Markdown
Member Author

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ✅

Changes: 1 file, 1 line changed. Removes com.fyralabs.Readymade.desktop from favorite-apps in gschema override.

Correctness

  • ✅ Readymade is the bootc installer — users were clicking it repeatedly from the dock
  • ✅ Removal is clean, no other entries affected
  • ✅ Firewall/Thunderbird/Nautilus/Bazaar/Software/Code entries preserved

Closes #213

  • ✅ Directly addresses the issue: "Remove the installation icon from the dock"

Verdict

Simple, correct, minimal. LGTM.

castrojo
castrojo previously approved these changes May 30, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 30, 2026
The installer (com.fyralabs.Readymade) was pinned in the GNOME dock.
Users see a delay before the installer window appears after first boot
and keep clicking the dock icon again, spawning duplicate prompts.

The installer auto-launches via its own mechanism, so the dock pin is
redundant. It remains accessible from the app menu.

Closes #213

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@castrojo castrojo force-pushed the fix/remove-installer-from-dock-213 branch from 8389a66 to 11a789c Compare May 30, 2026 04:35
@castrojo castrojo requested a review from ahmedadan as a code owner May 30, 2026 04:35
@castrojo castrojo enabled auto-merge May 30, 2026 04:35
@castrojo
Copy link
Copy Markdown
Contributor

🤖 Copilot Test Report

Branch: fix/remove-installer-from-dock-213 | 0 commits behind main | Tested: 2026-05-30T04:51Z

Test Results

Test Result
just check (syntax validation) ✅ PASS
Branch freshness ✅ Near head

Notes

Removes com.fyralabs.Readymade.desktop from favorite-apps in gschema override. Correct — Readymade is the installer, not needed post-install.

Copy link
Copy Markdown
Contributor

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving to satisfy merge queue requirement. Tested via just check — passes. See test report comment for details.

@castrojo
Copy link
Copy Markdown
Contributor

🔔 Needs 1 more approval to enter the merge queue. Ruleset requires 2 reviewers with write access. @castrojo has approved — one more maintainer needed.

@castrojo castrojo closed this May 30, 2026
auto-merge was automatically disabled May 30, 2026 07:38

Pull request was closed

@castrojo castrojo reopened this May 30, 2026
@castrojo castrojo closed this May 30, 2026
@castrojo castrojo reopened this May 30, 2026
@hanthor hanthor enabled auto-merge May 30, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/gnome Anything GNOME related kind/bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the installation icon from the dock

2 participants