fix: remove Readymade installer from dock favorite-apps#353
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR removes the Readymade installation icon ( ChangesGNOME Shell dock configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hanthor
left a comment
There was a problem hiding this comment.
Code Review ✅
Changes: 1 file, 1 line changed. Removes com.fyralabs.Readymade.desktop from favorite-apps in gschema override.
Correctness
- ✅ Readymade is the bootc installer — users were clicking it repeatedly from the dock
- ✅ Removal is clean, no other entries affected
- ✅ Firewall/Thunderbird/Nautilus/Bazaar/Software/Code entries preserved
Closes #213
- ✅ Directly addresses the issue: "Remove the installation icon from the dock"
Verdict
Simple, correct, minimal. LGTM.
The installer (com.fyralabs.Readymade) was pinned in the GNOME dock. Users see a delay before the installer window appears after first boot and keep clicking the dock icon again, spawning duplicate prompts. The installer auto-launches via its own mechanism, so the dock pin is redundant. It remains accessible from the app menu. Closes #213 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
8389a66 to
11a789c
Compare
🤖 Copilot Test ReportBranch: Test Results
NotesRemoves com.fyralabs.Readymade.desktop from favorite-apps in gschema override. Correct — Readymade is the installer, not needed post-install. |
castrojo
left a comment
There was a problem hiding this comment.
✅ Approving to satisfy merge queue requirement. Tested via just check — passes. See test report comment for details.
|
🔔 Needs 1 more approval to enter the merge queue. Ruleset requires 2 reviewers with write access. @castrojo has approved — one more maintainer needed. |
Summary
Removes
com.fyralabs.Readymade.desktopfrom the GNOME dockfavorite-appslist.The installer has a noticeable startup delay, so users who see the dock icon during first boot keep clicking it thinking it did not launch, resulting in duplicate installer windows. The installer auto-launches via its own mechanism and remains accessible from the app menu — the dock pin is purely redundant noise.
Closes #213
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit