feat(just): add ujust install-asus for ASUS laptop tools#339
Conversation
Adds install-asus recipe to apps.just that installs and activates both the asusctl system daemon (asusctl-linux) and the ROG Control Center GUI (rog-control-center-linux) from ublue-os/tap. Handles the full setup flow: brew install both casks, enable asusd.service + asus-shutdown.service via sudo, reload udev rules, and enable the asusd-user.service user unit. Closes projectbluefin#287 Closes projectbluefin#298 Assisted-by: claude-sonnet-4-5 via pi
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a new ChangesASUS Tools Installation Recipe
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hanthor
left a comment
There was a problem hiding this comment.
🤖 AI-Assisted Pull Request Review
Excellent and clean quality-of-life addition for ASUS laptop users!
Adding the install-asus recipe to apps.just makes managing both asusd and rog-control-center extremely straightforward.
Host Service Discovery Verification:
Verified that in Bazzite and Bluefin, the systemd search path is customized to include /home/linuxbrew/.linuxbrew directories (specifically under /home/linuxbrew/.linuxbrew/share/systemd/system or similar), which ensures the system-level systemd daemon can correctly discover and enable these brew-installed system services (asusd.service, asus-shutdown.service) as designed by this script.
Ready to be merged!
hanthor
left a comment
There was a problem hiding this comment.
Clean, complete recipe: installs both and , enables the system and user services, and reloads udev rules in the right order. CI passes. Approved.
🤖 Copilot Test ReportBranch: Test Results
Changes
|
Another QoL fix.
Adds install-asus recipe to apps.just that installs and activates both the asusctl system daemon (asusctl-linux) and the ROG Control Center GUI (rog-control-center-linux) from ublue-os/tap.
Handles the full setup flow: brew install both casks, enable asusd.service + asus-shutdown.service via sudo, reload udev rules, and enable the asusd-user.service user unit.
Closes #287
Closes #298
Assisted-by: claude-sonnet-4-5 via pi
Summary by CodeRabbit
New Features