Skip to content

feat(just): add ujust install-asus for ASUS laptop tools#339

Open
castrojo wants to merge 2 commits into
projectbluefin:mainfrom
castrojo:feat/ujust-asus
Open

feat(just): add ujust install-asus for ASUS laptop tools#339
castrojo wants to merge 2 commits into
projectbluefin:mainfrom
castrojo:feat/ujust-asus

Conversation

@castrojo
Copy link
Copy Markdown
Contributor

@castrojo castrojo commented May 19, 2026

Another QoL fix.

Adds install-asus recipe to apps.just that installs and activates both the asusctl system daemon (asusctl-linux) and the ROG Control Center GUI (rog-control-center-linux) from ublue-os/tap.

Handles the full setup flow: brew install both casks, enable asusd.service + asus-shutdown.service via sudo, reload udev rules, and enable the asusd-user.service user unit.

Closes #287
Closes #298

Assisted-by: claude-sonnet-4-5 via pi

Summary by CodeRabbit

New Features

  • Added an installation command for ASUS laptop tools, enabling easy setup of ASUS system control utilities and management software with automatic service configuration.

Review Change Stack

Adds install-asus recipe to apps.just that installs and activates
both the asusctl system daemon (asusctl-linux) and the ROG Control
Center GUI (rog-control-center-linux) from ublue-os/tap.

Handles the full setup flow: brew install both casks, enable
asusd.service + asus-shutdown.service via sudo, reload udev rules,
and enable the asusd-user.service user unit.

Closes projectbluefin#287
Closes projectbluefin#298

Assisted-by: claude-sonnet-4-5 via pi
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b0160bb2-f899-49ca-bed7-82ecdc87de4b

📥 Commits

Reviewing files that changed from the base of the PR and between 8c19806 and f7d9660.

📒 Files selected for processing (1)
  • system_files/shared/usr/share/ublue-os/just/apps.just

📝 Walkthrough

Walkthrough

This PR adds a new install-asus ujust recipe to the apps justfile that automates ASUS laptop tools installation and service configuration via Homebrew, including systemd enablement, udev reload, and user daemon activation.

Changes

ASUS Tools Installation Recipe

Layer / File(s) Summary
install-asus recipe implementation
system_files/shared/usr/share/ublue-os/just/apps.just
New recipe installs ASUS casks (asusctl-linux, rog-control-center-linux), enables systemd services, reloads udev, manages asusd-user.service, and displays usage hints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A recipe for ASUS lives!
Brew installs what the laptop gives,
Services enabled, udev reloads free—
Now ASUS users rejoice with glee! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ❓ Inconclusive The PR objectives note that VSCode Insiders was removed from ide.Brewfile, which appears unrelated to the ASUS installation feature and may be out of scope. Clarify whether the VSCode Insiders removal in ide.Brewfile was intentional and related to this PR, or if it should be reverted or submitted as a separate change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the primary change: adding a ujust recipe for ASUS laptop tools installation.
Description check ✅ Passed The description clearly outlines the changes, implementation details, linked issues, and contributors, though it does not follow the template structure provided.
Linked Issues check ✅ Passed The pull request successfully implements both linked issues: #287 (adds ASUS Homebrew packages support) and #298 (provides ujust command for ASUS user convenience).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added area/brew Homebrew things area/just Justfile things kind/enhancement New feature, don't implement without a spec and consensus labels May 19, 2026
Copy link
Copy Markdown
Member

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-Assisted Pull Request Review

Excellent and clean quality-of-life addition for ASUS laptop users!

Adding the install-asus recipe to apps.just makes managing both asusd and rog-control-center extremely straightforward.

Host Service Discovery Verification:
Verified that in Bazzite and Bluefin, the systemd search path is customized to include /home/linuxbrew/.linuxbrew directories (specifically under /home/linuxbrew/.linuxbrew/share/systemd/system or similar), which ensures the system-level systemd daemon can correctly discover and enable these brew-installed system services (asusd.service, asus-shutdown.service) as designed by this script.

Ready to be merged!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 24, 2026
Copy link
Copy Markdown
Member

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, complete recipe: installs both and , enables the system and user services, and reloads udev rules in the right order. CI passes. Approved.

Copy link
Copy Markdown
Member

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@castrojo castrojo enabled auto-merge May 30, 2026 04:29
@castrojo
Copy link
Copy Markdown
Contributor Author

🤖 Copilot Test Report

Branch: feat/ujust-asus | 55 commits behind main | Tested: 2026-05-30T04:52Z

Test Results

Test Result
just check (syntax validation) ✅ PASS
Branch freshness ⚠️ 55 commits behind main
Brewfile change: remove visual-studio-code-linux@insiders ✅ Removal — no validation needed

Changes

  • Adds ujust install-asus recipe to apps.just — installs asusctl-linux and rog-control-center-linux from ublue-os/tap, enables asusd.service and asusd-user.service
  • Removes visual-studio-code-linux@insiders from ide.Brewfile (separate from the ASUS feature)

⚠️ Action Required

55 commits behind main — needs a rebase. The VSCode Insiders removal should be confirmed as intentional (was it supposed to be part of this PR?)

@castrojo castrojo closed this May 30, 2026
auto-merge was automatically disabled May 30, 2026 07:39

Pull request was closed

@castrojo castrojo reopened this May 30, 2026
@castrojo castrojo closed this May 30, 2026
@castrojo castrojo reopened this May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/brew Homebrew things area/just Justfile things kind/enhancement New feature, don't implement without a spec and consensus lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ujust asus or something similar Add Asus brew packages

2 participants