π‘οΈ Sentinel: Fix XSS Vulnerability in VerificationRequest events#873
π‘οΈ Sentinel: Fix XSS Vulnerability in VerificationRequest events#873kevinaboos wants to merge 1 commit into
Conversation
Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel: [HIGH] Fix XSS Vulnerability in VerificationRequest events
π¨ Severity: HIGH
π‘ Vulnerability: Unsanitized HTML injection / Cross-Site Scripting (XSS) vulnerability was found in the display of
VerificationRequestevents. The target user ID (verification.to), which is user-controlled input, was directly interpolated into an HTML format string without escaping.π― Impact: A malicious actor could craft a
VerificationRequestwith a specially crafted user ID containing HTML/script tags. This would cause the client to render the injected HTML, potentially allowing XSS or other UI-based attacks.π§ Fix: Add
htmlize::escape_textto theverification.tofield before it is used in theformat!macros in bothsrc/event_preview.rsandsrc/home/room_screen.rs.β Verification: Ran
cargo check,cargo test --lib, andcargo clippyto ensure the build completes without errors or warnings and that no unrelated tests were broken.PR created automatically by Jules for task 8254878586460499012 started by @kevinaboos