Skip to content

πŸ›‘οΈ Sentinel: Fix XSS Vulnerability in VerificationRequest events#873

Closed
kevinaboos wants to merge 1 commit into
mainfrom
fix-xss-verification-request-8254878586460499012
Closed

πŸ›‘οΈ Sentinel: Fix XSS Vulnerability in VerificationRequest events#873
kevinaboos wants to merge 1 commit into
mainfrom
fix-xss-verification-request-8254878586460499012

Conversation

@kevinaboos
Copy link
Copy Markdown
Member

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS Vulnerability in VerificationRequest events

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Unsanitized HTML injection / Cross-Site Scripting (XSS) vulnerability was found in the display of VerificationRequest events. The target user ID (verification.to), which is user-controlled input, was directly interpolated into an HTML format string without escaping.
🎯 Impact: A malicious actor could craft a VerificationRequest with a specially crafted user ID containing HTML/script tags. This would cause the client to render the injected HTML, potentially allowing XSS or other UI-based attacks.
πŸ”§ Fix: Add htmlize::escape_text to the verification.to field before it is used in the format! macros in both src/event_preview.rs and src/home/room_screen.rs.
βœ… Verification: Ran cargo check, cargo test --lib, and cargo clippy to ensure the build completes without errors or warnings and that no unrelated tests were broken.


PR created automatically by Jules for task 8254878586460499012 started by @kevinaboos

Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@kevinaboos kevinaboos closed this May 20, 2026
@kevinaboos kevinaboos deleted the fix-xss-verification-request-8254878586460499012 branch May 20, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant