🛡️ Sentinel: [CRITICAL] Fix insecure session file persistence#752
🛡️ Sentinel: [CRITICAL] Fix insecure session file persistence#752kevinaboos wants to merge 1 commit intomainfrom
Conversation
…tricted permissions Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🚨 Severity: HIGH
💡 Vulnerability: The
save_sessionandsave_latest_user_idfunctions insrc/persistence/matrix_state.rswere usingtokio::fs::write, which writes files with default permissions (potentially world-readable depending on umask) and is not atomic. The session file contains sensitive information, including the database passphrase.🎯 Impact: Local attackers with access to the filesystem could read the session file and extract the database passphrase or hijack the user session.
🔧 Fix: Implemented
write_file_securelyinsrc/persistence/utils.rswhich:1. Writes to a temporary file with
0o600permissions (Unix).2. Atomically renames the temporary file to the target path.
Updated
matrix_state.rsto use this secure writing method.✅ Verification: Added a unit test in
src/persistence/utils.rsverifying that files are created with correct permissions (0o600 on Unix) and content is written correctly. Verified withcargo test persistence::utils.PR created automatically by Jules for task 17187642287887974361 started by @kevinaboos