Skip to content

Replace type suppression with proper type narrowing in rating middleware #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jan0707 merged 3 commits into from
Jan 20, 2026
Merged

Replace type suppression with proper type narrowing in rating middleware #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2c898c
Initial plan
Copilot Jan 20, 2026
19333d3
Replace @ts-ignore with proper type narrowing for vote parameter
Copilot Jan 20, 2026
654072e
Remove redundant type assertion after type guard
Copilot Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions nuxt-app/server/middleware/rating.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ export default eventHandler(async function(event) {
}

let slug = match[1];
let vote = match[2];
let voteString = match[2];

// Type narrowing: the regex already validated this is "up" or "down"
// We use a type guard to make TypeScript aware of this
if (voteString !== 'up' && voteString !== 'down') {
// This should never happen due to regex validation, but satisfies TypeScript
throw createError({ statusCode: 400, message: 'Invalid vote value' });
}
const vote = voteString;

const directus = useDirectus();

Expand All @@ -24,7 +32,6 @@ export default eventHandler(async function(event) {
throw createError({ statusCode: 404, message: 'Podcast not found' });
}

// @ts-ignore (Type-safety is enforced by regex)
try {
await directus.createRating(vote, podcast);

Expand Down