Skip to content

fix(ai-alibaba-cloud): require clean api base urls #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 24, 2026
+42 −2
Merged

fix(ai-alibaba-cloud): require clean api base urls #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion packages/ai/alibaba-cloud/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('Alibaba Cloud OpenAI-compatible generation', () => {
vi.stubGlobal('fetch', fetchMock);

await adapter.generate(ctx(), 'hello', { model: 'qwen-flash' }, {
baseUrl: 'https://dashscope-us.aliyuncs.com/compatible-mode/v1',
baseUrl: 'https://dashscope-us.aliyuncs.com/compatible-mode/v1/',
});

expect(fetchMock).toHaveBeenCalledWith(
Expand All @@ -101,6 +101,29 @@ describe('Alibaba Cloud OpenAI-compatible generation', () => {
);
});

it('rejects invalid or unclean custom base URLs before network calls', async () => {
const fetchMock = vi.fn();
vi.stubGlobal('fetch', fetchMock);

await expect(
adapter.generate(ctx(), 'hello', {}, { baseUrl: 'dashscope-us.aliyuncs.com/compatible-mode/v1' }),
).rejects.toThrow('valid URL');
await expect(
adapter.generate(ctx(), 'hello', {}, { baseUrl: 'ftp://dashscope-us.aliyuncs.com/compatible-mode/v1' }),
).rejects.toThrow('http or https');
await expect(
adapter.generate(ctx(), 'hello', {}, { baseUrl: 'https://user:pass@dashscope-us.aliyuncs.com/compatible-mode/v1' }),
).rejects.toThrow('clean API base');
await expect(
adapter.generate(ctx(), 'hello', {}, { baseUrl: 'https://dashscope-us.aliyuncs.com/compatible-mode/v1?target=chat' }),
).rejects.toThrow('clean API base');
await expect(
adapter.generate(ctx(), 'hello', {}, { baseUrl: 'https://dashscope-us.aliyuncs.com/compatible-mode/v1#chat' }),
).rejects.toThrow('clean API base');

expect(fetchMock).not.toHaveBeenCalled();
});

it('includes status and response body excerpt on errors', async () => {
vi.stubGlobal('fetch', vi.fn().mockResolvedValue({
ok: false,
Expand Down
19 changes: 18 additions & 1 deletion packages/ai/alibaba-cloud/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ export default defineAi<Config>({
if (opts.system) messages.push({ role: 'system', content: opts.system });
messages.push({ role: 'user', content: prompt });

const res = await fetch(`${config.baseUrl ?? DEFAULT_BASE}/chat/completions`, {
const baseUrl = cleanBaseUrl(config.baseUrl ?? DEFAULT_BASE);
const res = await fetch(`${baseUrl}/chat/completions`, {
method: 'POST',
headers: {
authorization: `Bearer ${apiKey}`,
Expand Down Expand Up @@ -70,6 +71,22 @@ export default defineAi<Config>({
}),
});

function cleanBaseUrl(value: string): string {
let url: URL;
try {
url = new URL(value);
} catch {
throw new Error('Alibaba Cloud baseUrl must be a valid URL');
}
if (url.protocol !== 'https:' && url.protocol !== 'http:') {
throw new Error('Alibaba Cloud baseUrl must use http or https');
}
if (url.username || url.password || url.search || url.hash) {
throw new Error('Alibaba Cloud baseUrl must be a clean API base without credentials, query, or hash');
}
return url.toString().replace(/\/+$/, '');
}

type AlibabaCloudRole = 'system' | 'user' | 'assistant' | 'tool';

interface AlibabaCloudMessage {
Expand Down
Loading