Conversation
Align the internal autoaway activity state with the actual initial login presence sent on successful reconnection. When reconnection succeeds we establish the initial presence (Online or Last status), but the internal `activity_state` remained in `ACTIVITY_ST_AWAY` or `ACTIVITY_ST_XA` because the state was never updated upon disconnect or reconnect. This led to two issues: 1. If the user reconnected as Online while remaining idle, the state was stuck in `ACTIVITY_ST_AWAY` and the client never went away again. 2. If the user returned and pressed a key, the client could not trigger a transition back to Online since it already thought they were active, causing the clients presence to get stuck in Away. Fixes: #2073 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the internal autoaway activity state with the actual initial login presence sent on successful reconnection.
When reconnection succeeds we establish the initial presence (Online or Last status), but the internal
activity_stateremained inACTIVITY_ST_AWAYorACTIVITY_ST_XAbecause the state was never updated upon disconnect or reconnect.This led to two issues:
ACTIVITY_ST_AWAYand the client never went away again.Fixes: #2073