fix: fix expiry date input in dc#264
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes missing handling of the card.invalid-date error code in Dynamic Checkout's card validation, ensuring the expiry-date error message is surfaced when a fully invalid expiry date is entered.
Changes:
- Add
card.invalid-dateas a fall-through case alongsidecard.invalid-month/card.invalid-yearinCardPaymentMethod.handleValidationError, targeting the existingexpiry-date-error-messageelement.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roshan-gorasia-cko
previously approved these changes
May 28, 2026
jakubjasinsky
force-pushed
the
fix-expiry-date-input
branch
from
4cc0839 to
796b736
Compare
roshan-gorasia-cko
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix expiry date validation error not displaying in Dynamic Checkout. The
card.invalid-dateerror code wasn't handled, so a fully invalid expiry datesilently failed to surface its error message.
Changes
card.invalid-datealongsidecard.invalid-month/card.invalid-yearin the card field error handler, so the expiry-date errormessage is shown.
card.invalid-date falls through the same case block as the existing month/year
errors, so it now targets the expiry-date-error-message element. Minimal,
single-line change in src/dynamic-checkout/payment-methods/card.ts.