GSOC 26: document multi-material and texture map support - #9068
Open
Nixxx19 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
phase 7 docs. updates the jsdoc for
loadModel(),model(), andbuildGeometry()so the reference explains multi-material and texture-map support, which the docs didn't mention before.loadModel(): expands the mtl note to say multi-material models are drawn per part, lists the texture maps a material can use (map_Kd,map_Ks,map_Ka,map_Ns,map_Bump), and documents the graceful fallback when a texture fails to loadmodel(): notes that the call is identical whether a model has one material or many, so a blender/sketchfab model shows up looking the way it was madebuildGeometry(): notes that switching texture/material mid-callback splits the result into parts, matching how a loaded multi-material model behaves, while a plainfill()change does not splitnotes
loadModelexample needs a hosted multi-material model asset, which is a separate follow-up)part of the gsoc multi-material .mtl work, follows #8879, #8955, #9063, #9066, and #9067.