GSOC 26: multi-material .mtl loading test coverage - #9065
Open
Nixxx19 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
rounds out the test coverage for multi-material .mtl loading (phase 6), on top of the parser/data layer from #8879 and the renderer from #8955. covers the happy path, the error modes, and the edges the proposal called out.
unit tests
parser (
parseMtl.js):loader (
loadModel.js):vnlinesvisual regression tests (
webgl.js)textured.obj)missing_texture.obj)multi_material_12.obj)single_material.obj)each visual test commits a stable reference screenshot.
fixtures added
missing_texture(404 map_Kd),multi_material_12(12 materials),single_material(one material).testing
part of the gsoc multi-material .mtl work, follows #8879 and #8955.