harden github actions #8650
+61
−33
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,13 +18,15 @@ jobs: | |
| INPUT_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| steps: | ||
| # 1. Setup | ||
| - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3 | ||
| with: | ||
| node-version: 22 | ||
| - name: Get semver info | ||
| id: semver | ||
| uses: akshens/semver-tag@8e427cd48c699c97d021df4946f3a0e65af5047e # v4 | ||
| with: | ||
| version: ${{ github.ref_name }} | ||
|
|
||
|
|
@@ -57,7 +59,7 @@ jobs: | |
| # 2. Prepare release files | ||
| - run: mkdir release && mkdir p5 && cp -r ./lib/* p5/ | ||
| - name: Create release zip file | ||
| uses: TheDoctor0/zip-release@09336613be18a8208dfa66bd57efafd9e2685657 # 0.6.2 | ||
| with: | ||
| type: zip | ||
| filename: release/p5.zip | ||
|
|
@@ -68,29 +70,30 @@ jobs: | |
|
|
||
| # 3. Release p5.js | ||
| - name: Create GitHub release | ||
| uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # v0.1.15 | ||
| with: | ||
| draft: true | ||
| prerelease: ${{ steps.semver.outputs.is-prerelease == 'true' }} | ||
| files: release/* | ||
| generate_release_notes: true | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
Member
There was a problem hiding this comment. @perminder-17 I don't think the token should change (or, why should it?)
Collaborator
Author
There was a problem hiding this comment. In Step 3
Member
There was a problem hiding this comment. Ah sure! Then |
||
| - name: Publish to NPM | ||
| uses: JS-DevTools/npm-publish@0f451a94170d1699fd50710966d48fb26194d939 | ||
| with: | ||
| token: ${{ secrets.NPM_TOKEN }} | ||
| tag: ${{ steps.semver.outputs.is-prerelease != 'true' && 'latest' || 'beta' }} | ||
|
|
||
| # 4. Update p5.js website | ||
| - name: Clone p5.js website | ||
| if: ${{ steps.semver.outputs.is-prerelease != 'true' }} | ||
| uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3 | ||
| with: | ||
| repository: processing/p5.js-website | ||
| ref: '2.0' | ||
| path: website | ||
| fetch-depth: 0 | ||
| token: ${{ secrets.ACCESS_TOKEN }} | ||
| persist-credentials: false | ||
| - name: Updated website files | ||
| if: ${{ steps.semver.outputs.is-prerelease != 'true' }} | ||
| run: | | ||
|
|
@@ -111,7 +114,7 @@ jobs: | |
| git commit -m "Update p5.js to ${{ github.ref_name }}" | ||
| - name: Push updated website repo | ||
| if: ${{ steps.semver.outputs.is-prerelease != 'true' }} | ||
| uses: ad-m/github-push-action@40bf560936a8022e68a3c00e7d2abefaf01305a6 # v0.6.0 | ||
| with: | ||
| github_token: ${{ secrets.ACCESS_TOKEN }} | ||
| branch: '2.0' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://about.codecov.io/apr-2021-post-mortem/
This actually happened in real life in 2021, Codecov's bash uploader was compromised and attackers stole secrets/tokens from thousands of CI pipelines. @ksen0 @davepagurek @limzykenneth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not really utilizing it at the moment so it probably can be skipped entirely. We'll do code coverage in Vitest for 2.x at some point and reporting can either use a service like this or even our own bot.