-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
docs: remove deprecated beginGeometry() and endGeometry() references #8642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ksen0
merged 4 commits into
processing:dev-2.0
from
codervinitjangir:fix/buildGeometry-docs
Mar 21, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
eb2d0d2
docs: remove broken links to beginGeometry/endGeometry in v2.0
codervinitjangir 6770cb9
Merge remote-tracking branch 'upstream/dev-2.0' into fix/buildGeometr…
codervinitjangir a2adbaa
docs: resolve PR feedback - revert private docs and fix buildGeometry…
codervinitjangir 3f6ce7c
Merge branch 'dev-2.0' into fix/buildGeometry-docs
codervinitjangir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -418,12 +418,11 @@ export class Renderer3D extends Renderer { | |
| /** | ||
| * Starts creating a new p5.Geometry. Subsequent shapes drawn will be added | ||
| * to the geometry and then returned when | ||
| * <a href="#/p5/endGeometry">endGeometry()</a> is called. One can also use | ||
| * <a href="#/p5/buildGeometry">buildGeometry()</a> to pass a function that | ||
| * draws shapes. | ||
| * | ||
| * If you need to draw complex shapes every frame which don't change over time, | ||
| * combining them upfront with `beginGeometry()` and `endGeometry()` and then | ||
| * combining them upfront with `buildGeometry()` and then | ||
| * drawing that will run faster than repeatedly drawing the individual pieces. | ||
| * @private | ||
| */ | ||
|
|
@@ -440,7 +439,7 @@ export class Renderer3D extends Renderer { | |
|
|
||
| /** | ||
| * Finishes creating a new <a href="#/p5.Geometry">p5.Geometry</a> that was | ||
| * started using <a href="#/p5/beginGeometry">beginGeometry()</a>. One can also | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change does not make sense. This is a private method. |
||
| * One can also | ||
| * use <a href="#/p5/buildGeometry">buildGeometry()</a> to pass a function that | ||
| * draws shapes. | ||
| * @private | ||
|
|
@@ -472,9 +471,6 @@ export class Renderer3D extends Renderer { | |
| * combining them with `buildGeometry()` once and then drawing that will run | ||
| * faster than repeatedly drawing the individual pieces. | ||
| * | ||
| * One can also draw shapes directly between | ||
| * <a href="#/p5/beginGeometry">beginGeometry()</a> and | ||
| * <a href="#/p5/endGeometry">endGeometry()</a> instead of using a callback | ||
| * function. | ||
| * @param {Function} callback A function that draws shapes. | ||
| * @returns {p5.Geometry} The model that was built from the callback function. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,12 +111,6 @@ function primitives3D(p5, fn){ | |
| * will run faster than repeatedly drawing the individual pieces. | ||
| * | ||
| * The parameter, `callback`, is a function with the drawing instructions for | ||
| * the new <a href="#/p5.Geometry">p5.Geometry</a> object. It will be called | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| * once to create the new 3D shape. | ||
| * | ||
| * See <a href="#/p5/beginGeometry">beginGeometry()</a> and | ||
| * <a href="#/p5/endGeometry">endGeometry()</a> for another way to build 3D | ||
| * shapes. | ||
| * | ||
| * Note: `buildGeometry()` can only be used in WebGL mode. | ||
| * | ||
|
|
@@ -321,12 +315,8 @@ function primitives3D(p5, fn){ | |
| * <a href="#/p5.Geometry">p5.Geometry</a> objects can contain lots of data | ||
| * about their vertices, surface normals, colors, and so on. Complex 3D shapes | ||
| * can use lots of memory which is a limited resource in many GPUs. Calling | ||
| * `freeGeometry()` can improve performance by freeing a | ||
| * <a href="#/p5.Geometry">p5.Geometry</a> object’s resources from GPU memory. | ||
| * `freeGeometry()` works with <a href="#/p5.Geometry">p5.Geometry</a> objects | ||
| * created with <a href="#/p5/beginGeometry">beginGeometry()</a> and | ||
| * <a href="#/p5/endGeometry">endGeometry()</a>, | ||
| * <a href="#/p5/buildGeometry">buildGeometry()</a>, and | ||
| * created with <a href="#/p5/buildGeometry">buildGeometry()</a> and | ||
| * <a href="#/p5/loadModel">loadModel()</a>. | ||
| * | ||
| * The parameter, `geometry`, is the <a href="#/p5.Geometry">p5.Geometry</a> | ||
|
|
@@ -342,24 +332,6 @@ function primitives3D(p5, fn){ | |
| * @param {p5.Geometry} geometry 3D shape whose resources should be freed. | ||
| * | ||
| * @example | ||
| * function setup() { | ||
| * createCanvas(100, 100, WEBGL); | ||
| * | ||
| * background(200); | ||
| * | ||
| * // Create a p5.Geometry object. | ||
| * beginGeometry(); | ||
| * cone(); | ||
| * let shape = endGeometry(); | ||
| * | ||
| * // Draw the shape. | ||
| * model(shape); | ||
| * | ||
| * // Free the shape's resources. | ||
| * freeGeometry(shape); | ||
| * } | ||
| * | ||
| * @example | ||
| * // Click and drag the mouse to view the scene from different angles. | ||
| * | ||
| * let button; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the one below - this does not make sense, it's a private method. It has not been fully removed but it is not in the reference.