Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/core/p5.Renderer3D.js
Original file line number Diff line number Diff line change
Expand Up @@ -418,12 +418,11 @@ export class Renderer3D extends Renderer {
/**
* Starts creating a new p5.Geometry. Subsequent shapes drawn will be added
* to the geometry and then returned when
* <a href="#/p5/endGeometry">endGeometry()</a> is called. One can also use
* <a href="#/p5/buildGeometry">buildGeometry()</a> to pass a function that
* draws shapes.
*
* If you need to draw complex shapes every frame which don't change over time,
* combining them upfront with `beginGeometry()` and `endGeometry()` and then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the one below - this does not make sense, it's a private method. It has not been fully removed but it is not in the reference.

* combining them upfront with `buildGeometry()` and then
* drawing that will run faster than repeatedly drawing the individual pieces.
* @private
*/
Expand All @@ -440,7 +439,7 @@ export class Renderer3D extends Renderer {

/**
* Finishes creating a new <a href="#/p5.Geometry">p5.Geometry</a> that was
* started using <a href="#/p5/beginGeometry">beginGeometry()</a>. One can also
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not make sense. This is a private method.

* One can also
* use <a href="#/p5/buildGeometry">buildGeometry()</a> to pass a function that
* draws shapes.
* @private
Expand Down Expand Up @@ -472,9 +471,6 @@ export class Renderer3D extends Renderer {
* combining them with `buildGeometry()` once and then drawing that will run
* faster than repeatedly drawing the individual pieces.
*
* One can also draw shapes directly between
* <a href="#/p5/beginGeometry">beginGeometry()</a> and
* <a href="#/p5/endGeometry">endGeometry()</a> instead of using a callback
* function.
* @param {Function} callback A function that draws shapes.
* @returns {p5.Geometry} The model that was built from the callback function.
Expand Down
30 changes: 1 addition & 29 deletions src/webgl/3d_primitives.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,6 @@ function primitives3D(p5, fn){
* will run faster than repeatedly drawing the individual pieces.
*
* The parameter, `callback`, is a function with the drawing instructions for
* the new <a href="#/p5.Geometry">p5.Geometry</a> object. It will be called
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change results in incomplete text:

Image

* once to create the new 3D shape.
*
* See <a href="#/p5/beginGeometry">beginGeometry()</a> and
* <a href="#/p5/endGeometry">endGeometry()</a> for another way to build 3D
* shapes.
*
* Note: `buildGeometry()` can only be used in WebGL mode.
*
Expand Down Expand Up @@ -321,12 +315,8 @@ function primitives3D(p5, fn){
* <a href="#/p5.Geometry">p5.Geometry</a> objects can contain lots of data
* about their vertices, surface normals, colors, and so on. Complex 3D shapes
* can use lots of memory which is a limited resource in many GPUs. Calling
* `freeGeometry()` can improve performance by freeing a
* <a href="#/p5.Geometry">p5.Geometry</a> object’s resources from GPU memory.
* `freeGeometry()` works with <a href="#/p5.Geometry">p5.Geometry</a> objects
* created with <a href="#/p5/beginGeometry">beginGeometry()</a> and
* <a href="#/p5/endGeometry">endGeometry()</a>,
* <a href="#/p5/buildGeometry">buildGeometry()</a>, and
* created with <a href="#/p5/buildGeometry">buildGeometry()</a> and
* <a href="#/p5/loadModel">loadModel()</a>.
*
* The parameter, `geometry`, is the <a href="#/p5.Geometry">p5.Geometry</a>
Expand All @@ -342,24 +332,6 @@ function primitives3D(p5, fn){
* @param {p5.Geometry} geometry 3D shape whose resources should be freed.
*
* @example
* function setup() {
* createCanvas(100, 100, WEBGL);
*
* background(200);
*
* // Create a p5.Geometry object.
* beginGeometry();
* cone();
* let shape = endGeometry();
*
* // Draw the shape.
* model(shape);
*
* // Free the shape's resources.
* freeGeometry(shape);
* }
*
* @example
* // Click and drag the mouse to view the scene from different angles.
*
* let button;
Expand Down
4 changes: 1 addition & 3 deletions src/webgl/loading.js
Original file line number Diff line number Diff line change
Expand Up @@ -972,9 +972,7 @@ function loading(p5, fn){
* The parameter, `model`, is the
* <a href="#/p5.Geometry">p5.Geometry</a> object to draw.
* <a href="#/p5.Geometry">p5.Geometry</a> objects can be built with
* <a href="#/p5/buildGeometry">buildGeometry()</a>, or
* <a href="#/p5/beginGeometry">beginGeometry()</a> and
* <a href="#/p5/endGeometry">endGeometry()</a>. They can also be loaded from
* <a href="#/p5/buildGeometry">buildGeometry()</a>. They can also be loaded from
* a file with <a href="#/p5/loadGeometry">loadGeometry()</a>.
*
* Note: `model()` can only be used in WebGL mode.
Expand Down