Skip to content

fix(image): use FES for setFrame validation errors (#8610) #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gourijain029-del wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix(image): use FES for setFrame validation errors (#8610) #8613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/image/p5.Image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ p5.Image = class {
*/
pixelDensity(density) {
if (typeof density !== 'undefined') {
// Setter: set the density and handle resize
// Setter: set the density and handle resize
if (density <= 0) {
const errorObj = {
type: 'INVALID_VALUE',
Expand All @@ -334,7 +334,7 @@ p5.Image = class {

return this; // Return the image instance for chaining if needed
} else {
// Getter: return the default density
// Getter: return the default density
return this._pixelDensity;
}
}
Expand Down Expand Up @@ -1808,7 +1808,7 @@ p5.Image = class {
props.displayIndex = index;
this.drawingContext.putImageData(props.frames[index].image, 0, 0);
} else {
console.log(
p5._friendlyError(
'Cannot set GIF to a frame number that is higher than total number of frames or below zero.'
);
}
Expand Down