Fix: prevent unnecessary webgl canvas recreation in noSmooth()#8303
Open
yaxit24 wants to merge 2 commits intoprocessing:mainfrom
Open
Fix: prevent unnecessary webgl canvas recreation in noSmooth()#8303yaxit24 wants to merge 2 commits intoprocessing:mainfrom
yaxit24 wants to merge 2 commits intoprocessing:mainfrom
Conversation
Author
|
@ksen0 @perminder-17 Please review. |
perminder-17
requested changes
Dec 6, 2025
Collaborator
perminder-17
left a comment
perminder-17
left a comment
There was a problem hiding this comment.
Hi, there are lot of extra spacing changes in your code which makes it hard to review. Can you please fix it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7548
Changes:
I fixed a bug where calling noSmooth() in WebGL mode would unnecessarily recreate the canvas, causing it to lose its CSS positioning. The fix involves checking the actual WebGL context attributes to see if antialiasing is already disabled before attempting to disable it again.
npm run lintpasses