feat(typography): add JUSTIFIED horizontal alignment for bounded text in 2D renderer#8294
Open
Vansh0204 wants to merge 4 commits intoprocessing:mainfrom
Open
feat(typography): add JUSTIFIED horizontal alignment for bounded text in 2D renderer#8294Vansh0204 wants to merge 4 commits intoprocessing:mainfrom
Vansh0204 wants to merge 4 commits intoprocessing:mainfrom
Conversation
…erer - Justifies non-final lines in bounded text() - Keeps final line ragged - Maps Canvas2D textAlign to LEFT when JUSTIFIED is set - WEBGL remains left-aligned for now Refs processing#7712
Vansh0204
force-pushed
the
feat/justified-align-pr1
branch
from
96200c1 to
05aa09a
Compare
Contributor
|
@Vansh0204 have you created tests for this feature? |
Author
|
Thanks for reviewing, sir! I haven't added tests yet – I'll add comprehensive unit tests for JUSTIFIED alignment in the 2D renderer covering inter-word spacing distribution and edge cases. I'll push them shortly. |
Contributor
|
a good place to start would be the alignment tests in 
eventually we will also need pixel-based tests like those here: https://github.com/processing/p5.js/blob/dev-2.0/test/unit/visual/cases/typography.js |
Author
|
Hi @dhowe, sir! I've updated the PRs to include the necessary tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1
Addresses #7712