Skip to content

Fixed scrollbar in example output frame#745

Closed
Its-sunny69 wants to merge 18 commits into
processing:mainfrom
Its-sunny69:fixing-scrollbar
Closed

Fixed scrollbar in example output frame#745
Its-sunny69 wants to merge 18 commits into
processing:mainfrom
Its-sunny69:fixing-scrollbar

Conversation

@Its-sunny69

Copy link
Copy Markdown

Fixes #716
Partially addresses processing/p5.js#7620

@ksen0

ksen0 commented Mar 24, 2025

Copy link
Copy Markdown
Member

Hello @Its-sunny69 - so the overflow: hidden solution affects not only the case you showed, but also the example that @davepagurek is describing in the comment on the related issue that should have scrollbars: https://p5js.org/reference/p5/input/ - that comment also suggests making the fix a bit more targeted:

It seems like this issue also talks specifically about scroll bars for sketches that already have correctly-sized frames, but where scroll bars appear when zoomed in at certain levels. I think another valid solution could be to figure out how to remove scroll bars in just those cases, but still keeping scroll bars for the case where something is truly outside of the canvas and needs to scroll.

Could you update your solution to more specifically target your particular case, please?

@Its-sunny69

Its-sunny69 commented Mar 25, 2025

Copy link
Copy Markdown
Author

@ksen0 Thanks for providing more clarity on this issue, i will look for more specific solution .

Comment thread package.json
"js-yaml": "^4.1.0",
"keyword-extractor": "^0.0.28",
"lodash": "^4.17.21",
"p5.js-website": "file:",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave out package and package-lock from the PR, like with git ignore please?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@Its-sunny69

Copy link
Copy Markdown
Author

Hey @ksen0 , if this PR solution is still valid and correct then please merge it.

@doradocodes

Copy link
Copy Markdown
Contributor

Closing this PR since the commit will be merged here: #1431

@doradocodes doradocodes closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrolls in example code output frame seems unnecessary

4 participants