Add p5.sound CDN link to download page - #1560
Conversation
ksen0
left a comment
ksen0
left a comment
There was a problem hiding this comment.
Thanks! Just 2 minor things then it will be ready to merge. @doradocodes please feel free t omerge if you get to it before I do and the comments are addressed, thank you in advance
|
|
||
| ### Download the Complete Library | ||
| This is a download containing the p5.js library file, the p5.sound addon, and an example project. It does not contain an editor. Visit [Get Started](/tutorials/get-started) to learn how to setup a p5.js project. | ||
| This is a download containing the p5.js library file and an example project. It does not contain an editor. Visit [Get Started](/tutorials/get-started) to learn how to setup a p5.js project. |
There was a problem hiding this comment.
How about: "It does not contain an editor. It also does not contain p5.sound.js; please see below instructions for sound support."
There was a problem hiding this comment.
Updated, thanks! Now reads: "It does not contain an editor. It also does not contain p5.sound.js; please see below instructions for sound support."
| <LinkButton variant='download' url={minifiedLibraryDownloadUrl}> p5.min.js </LinkButton> | ||
| </div> | ||
|
|
||
| ### Sound Support with p5.sound |
There was a problem hiding this comment.
The jsdelivr package is "p5.sound" but the library and repo name is p5.sound.js. Please use "p5.sound.js" to refer to it in the title and the text. Sorry for the inconvenience!
There was a problem hiding this comment.
Updated, section is now titled "Sound Support with p5.sound.js" and the body text uses p5.sound.js consistently. Left the jsDelivr URL and link text pointing at the actual npm package name (p5.sound) since that's what jsDelivr calls it.
|
Hi @AmanUllah687, thank you for this PR. One little thing I noticed while reading through it: the download page now says the zip "does not contain p5.sound.js." From your comment on issue #9037 though, it sounds like the old p5.sound.js file is still bundled into the zip for now, and will only be removed once the follow-up PR in the p5.js repo lands. So the wording is a little ahead of itself, describing something as already done when it's actually still one step away from being done. Could you tweak the wording slightly so it matches where things stand right now? Thanks again for all the work on this. |
Good catch, thank you, you're right, the old file is still in the zip until the p5.js repo PR lands. Updated the wording to reflect the current state accurately rather than getting ahead of things. |
3 participants
Part of processing/p5.js#9037
p5.sound is being removed from the p5.js complete library zip since it's
now maintained as a separate library. This adds a section to the download
page linking to the current p5.sound CDN build (using the existing but
previously-unused
cdnSoundUrlglobal) and the jsDelivr package page.