Skip to content

Setting up your environment simplified chinese#1442

Open
luciawang0901 wants to merge 3 commits into
processing:mainfrom
luciawang0901:setting-up-your-environment-Simplified-Chinese
Open

Setting up your environment simplified chinese#1442
luciawang0901 wants to merge 3 commits into
processing:mainfrom
luciawang0901:setting-up-your-environment-Simplified-Chinese

Conversation

@luciawang0901

Copy link
Copy Markdown

I have made all the changes according to your review comments. Please take another look. Thank you! @lirenjie95

I have made all the changes according to your review comments. Please take another look. Thank you!
@lirenjie95

Copy link
Copy Markdown
Contributor

@luciawang0901, thank you for the update! To keep our review history consolidated, could you please continue the discussion on the original PR and close this current one? The previous review comments are already on the old PR, so it would be best to maintain the context there. Appreciate your understanding!

@lirenjie95

Copy link
Copy Markdown
Contributor

By the way, in the previous PR description, click "..." and then you can see "edit". You can write Resolves #1379 to link the issue.

@luciawang0901

Copy link
Copy Markdown
Author

Hi @lirenjie95, Thank you so much for your review.

I made the updates according to your review comments, but I accidentally pushed them to a new branch. That's why I created this new PR.

If this new PR is closed, will the updates still show up in the previous PR? Or do I need to update the previous PR again?

Sorry for the confusion, and thank you for your help!

@lirenjie95

Copy link
Copy Markdown
Contributor

You have to update the previous PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants