Skip to content

Fixed sketch and play/pause buttons going off screen when scrolling #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Nebulaics wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fixed sketch and play/pause buttons going off screen when scrolling #1405

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5956b1f
Added experimental sticky attribute
Nebulaics May 15, 2026
1432d61
Sketch and play/stop buttons are now visible when scrolling
Nebulaics May 15, 2026
438971a
Merge branch 'main' of https://github.com/Nebulaics/p5.js-website int…
Nebulaics May 15, 2026
0114bf9
Merge branch 'main' into dev/sticky
Nebulaics May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/CodeEmbed/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@ export const CodeEmbed = (props) => {

return (
<div
className={`my-md flex w-full flex-col gap-[20px] overflow-hidden ${props.allowSideBySide ? "lg:flex-row" : ""} ${props.fullWidth ? "full-width" : ""}`}
className={`my-md flex w-full flex-col gap-[20px] overflow-y-auto max-h-screen ${props.allowSideBySide ? "lg:flex-row" : ""} ${props.fullWidth ? "full-width" : ""}`}
>
{props.previewable ? (
<div
className={`ml-0 flex w-fit gap-[20px] ${largeSketch ? "flex-col" : (props.allowSideBySide ? "" : "flex-col lg:flex-row")}`}
className={`sticky top-0 right-0 ml-0 flex w-fit gap-[20px] ${largeSketch ? "flex-col" : (props.allowSideBySide ? "" : "flex-col lg:flex-row")}`}
>
<div>
<CodeFrame
Expand Down Expand Up @@ -129,7 +129,7 @@ export const CodeEmbed = (props) => {
</div>
</div>
) : null}
<div className="code-editor-container relative w-full">
<div className="code-editor-container w-full">
<CodeMirror
value={codeString}
theme="light"
Expand All @@ -155,7 +155,7 @@ export const CodeEmbed = (props) => {
(editorView.contentDOM.ariaLabel = "Code Editor")
}
/>
<div className="absolute right-0 top-0 flex flex-col gap-xs p-xs md:flex-row">
<div className="sticky absolute right-0 top-0 flex flex-col gap-xs p-xs md:flex-row">
<CopyCodeButton textToCopy={codeString || initialCode} />
<CircleButton
onClick={() => {
Expand Down
Loading