Skip to content

Fix/tooltip overflow issue #4050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jatin78600 wants to merge 5 commits into
base: develop
Choose a base branch
from
+43 −14
Open

Fix/tooltip overflow issue #4050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f42395
feat: add tooltip to collection item remove button
jatin78600 Mar 26, 2026
ea2927e
fix(ui): prevent tooltip overflow by switching to right-alignment and…
jatin78600 Mar 28, 2026
b477eb7
fix: resolve tooltip overflow and horizontal scroll in collection table
jatin78600 Mar 28, 2026
e9781db
Replace X button with dropdown menu in CollectionItemRow for better U…
jatin78600 Mar 28, 2026
a907835
Merge branch 'develop' into fix/tooltip-overflow-issue
jatin78600 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions client/modules/User/components/CollectionItemRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ import React from 'react';
import { Link } from 'react-router-dom';
import { useTranslation } from 'react-i18next';
import { useDispatch } from 'react-redux';
import { TableDropdown } from '../../../components/Dropdown/TableDropdown';
import { MenuItem } from '../../../components/Dropdown/MenuItem';
import { Tooltip } from '../../../common/Tooltip';
import { removeFromCollection } from '../../IDE/actions/collections';
import { formatDateToString } from '../../../utils/formatDate';
import RemoveIcon from '../../../images/close.svg';
import { removeFromCollection } from '../../IDE/actions/collections';

const CollectionItemRow = ({ collection, item, isOwner }) => {
const { t } = useTranslation();
Expand Down Expand Up @@ -44,17 +48,26 @@ const CollectionItemRow = ({ collection, item, isOwner }) => {
}`}
>
<th scope="row">{name}</th>

<td>{formatDateToString(item.createdAt)}</td>

<td>{sketchOwnerUsername}</td>

<td className="collection-row__action-column">
{isOwner && (
<button
className="collection-row__remove-button"
onClick={handleSketchRemove}
aria-label={t('Collection.SketchRemoveARIA')}
>
<RemoveIcon focusable="false" aria-hidden="true" />
</button>
<TableDropdown aria-label={t('SketchList.ToggleLabelARIA')}>
<MenuItem onClick={handleSketchRemove}>
{t('RemoveFromCollection')}
</MenuItem>
</TableDropdown>
<Tooltip content={t('RemoveFromCollection')}>
<button
className="collection-row__remove-button"
onClick={handleSketchRemove}
>
<RemoveIcon focusable="false" aria-hidden="true" />
</button>
</Tooltip>
)}
</td>
</tr>
Expand Down
27 changes: 21 additions & 6 deletions client/styles/components/_tooltip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,17 @@
font-family: Montserrat, sans-serif;
font-size: 1rem;
padding: 0.5rem 0.75rem;
max-width: none;
max-width: 250px;
width: max-content;
white-space: nowrap;
left: 1rem;
right: auto;
position:absolute;
bottom: 100%;
margin-bottom: 8px;
left: auto;
right: -0.5rem;
transform: translateX(0);
text-align: left;
text-align: right;
word-wrap: break-word;
}

.tooltip-wrapper .tooltipped-n::before,
Expand All @@ -26,7 +31,17 @@
color: getThemifyVariable('button-background-hover-color');
border-top-color: getThemifyVariable('button-background-hover-color');
}
left: 1.75rem;
right: auto;
content: "";
left: auto;
position: absolute;
bottom: 100%;
margin-bottom: 2px;
right: 0.25rem;
transform: translateX(0);
border: 6px solid transparent;
@include themify() {
border-top-color: getThemifyVariable('button-background-hover-color');
}
}


3 changes: 2 additions & 1 deletion translations/locales/it/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,8 @@
"TitleDefault": "collezione"
},
"Collection": {
"Title": "p5.js redattore web | Mie collezioni",
"RemoveFromCollection":"Remove from Collection ",
"Title": "p5.js redattore web | My collezioni",
"AnothersTitle": "p5.js redattore web | Le collezioni di {{anotheruser}}",
"Share": "Condividi",
"URLLink": "Collegamento alla collezione",
Expand Down