fix: don't render empty ul when folder has no children#4047
Open
geeta102 wants to merge 1 commit intoprocessing:developfrom
Open
fix: don't render empty ul when folder has no children#4047geeta102 wants to merge 1 commit intoprocessing:developfrom
geeta102 wants to merge 1 commit intoprocessing:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes # 4039
Demo:
Not applicable here as this is not a UI change. The fix removes
an empty
<ul>from the DOM when a folder hasno children, which improves screen reader
experience but has no visual impact.
Changes:
Added children.length > 0 condition in
FileNode.jsx to prevent rendering empty
ul element when folder has no children
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123