Skip to content

fix: don't render empty ul when folder has no children#4047

Open
geeta102 wants to merge 1 commit intoprocessing:developfrom
geeta102:fix/empty_list
Open

fix: don't render empty ul when folder has no children#4047
geeta102 wants to merge 1 commit intoprocessing:developfrom
geeta102:fix/empty_list

Conversation

@geeta102
Copy link
Copy Markdown

Issue:

Fixes # 4039

Demo:

Not applicable here as this is not a UI change. The fix removes
an empty <ul> from the DOM when a folder has
no children, which improves screen reader
experience but has no visual impact.

Changes:

Added children.length > 0 condition in
FileNode.jsx to prevent rendering empty
ul element when folder has no children

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant