feat: add tooltip to collection item remove button #4041
feat: add tooltip to collection item remove button #4041jatin78600 wants to merge 1 commit intoprocessing:developfrom
Conversation
|
"Hi @raclim I’m a B.Sc. student and this is my first contribution to the p5.js web editor. I have fixed Issue #3882 by adding a hover tooltip to the 'Remove from Collection' button. I used the shared Tooltip component and ensured the text is pulled from the translation files for better accessibility and localization. I've verified that the linter passes and the UI looks correct. I’m eager to learn, so please let me know if any changes are needed. Thank you for the guidance!" it was great for me to do contribution in such a inspiring project ..now i am going addicted of this and i will not stop contributing |
|
Hi @jatin78600, thanks for the PR. I noticed in the preview that some parts aren’t fully visible, so it would be great if you could take another look and fix that. |
|
can you please elaborate it more in detail so that it will good for me to fix it thanks for response sir |

Hi @raclim
Issue:
Fixes #3882
Added a hover tooltip to the "Remove from Collection" button in the CollectionItemRow component. Currently, the button only has an x icon, which might be unclear to users; this PR provides text feedback ("Remove from collection") to improve UX and accessibility.
Demo:
Changes:
Component Update: Wrapped the button in CollectionItemRow.jsx with the shared Tooltip component.
Prop Mapping: Passed the translated string to the content prop of the Tooltip.
I have Added the RemoveFromCollection key to client/i18n/locales/en-US/translation.json and client/i18n/locales/it-IT/translation.json.
I have verified that this pull request:
has no linting errors (
npm run lint)has no test errors (
npm run test)has no typecheck errors (
npm run typecheck)is from a uniquely-named feature branch and is up to date with the
developbranch.is descriptively named and links to an issue number, i.e.
Fixes #123meets the standards outlined in the accessibility guidelines