Add data-testid attributes to Play and Stop buttons for E2E testing#4037
Open
sanchit955 wants to merge 1 commit intoprocessing:developfrom
Open
Add data-testid attributes to Play and Stop buttons for E2E testing#4037sanchit955 wants to merge 1 commit intoprocessing:developfrom
sanchit955 wants to merge 1 commit intoprocessing:developfrom
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Author
|
Happy to add corresponding Playwright E2E tests for these selectors if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
data-testidattributes to the Play and Stop buttons in the toolbar to support stable E2E testing.Changes
data-testid="play-button"to the main Play button (id="play-sketch")data-testid="stop-button"to the Stop buttonWhy
Currently, E2E tests rely on fragile selectors like CSS classes or IDs, which may change during refactoring or styling updates.
Using
data-testidprovides a stable and explicit contract between the UI and test code, improving test reliability.Impact