fix: await autosave before downloading sketch zip#4022
Open
saschabuehrle wants to merge 1 commit intoprocessing:developfrom
Open
fix: await autosave before downloading sketch zip#4022saschabuehrle wants to merge 1 commit intoprocessing:developfrom
saschabuehrle wants to merge 1 commit intoprocessing:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#4021 — Downloaded ZIP filename uses the old sketch name instead of the current one when the sketch has been renamed but the rename hasn't been saved to the server yet.
Root cause
In
useSketchActions.js,downloadSketch()callsdispatch(autosaveProject())and then immediately callsexportProjectAsZip(). SinceautosaveProjectis async (it issues a PUT request to the server), the download URL is opened before the save completes, so the server still has the old name when it generates the ZIP and itsContent-Dispositionfilename.Fix
awaitthe autosave dispatch so the server has the updated sketch name before the ZIP download begins. TheautosaveProjectthunk already returns a Promise from the underlyingsaveProjectcall, so making the functionasyncand addingawaitis all that's needed.Testing
Happy to address any feedback.
Greetings, saschabuehrle