fix: remove duplicate Mongoose index on username and email fields#4016
Open
Ambuj123554 wants to merge 1 commit intoprocessing:developfrom
Open
fix: remove duplicate Mongoose index on username and email fields#4016Ambuj123554 wants to merge 1 commit intoprocessing:developfrom
Ambuj123554 wants to merge 1 commit intoprocessing:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3752
When running the backend locally, Mongoose throws duplicate index
warnings for both the
usernameandemailfields on startup.This was caused by having both
unique: truein the schema fielddefinition AND a separate
userSchema.index()call for the samefields, resulting in two index definitions for each field.
Demo:
No UI changes — this is a backend fix. The Mongoose warnings no
longer appear on server startup after this fix.
Changes:
unique: truefrom theusernamefield definitionunique: truefrom theemailfield definitionby the existing
userSchema.index()calls at the bottom of thefile, which already include the correct collation settings
I have verified that this pull request:
npm run lint)npm run test) — note:npm run testfails on Windows due to NODE_ENV syntax, unrelated to this fix
npm run typecheck)with the
developbranch.