refactor: export mxGraph objects directly instead of via mxgraph namespace#3491
Draft
refactor: export mxGraph objects directly instead of via mxgraph namespace#3491
Conversation
…space Destructure mxGraph objects from the mxgraph factory export so internal code imports them directly (e.g. `mxGraph`, `mxConstants`) rather than accessing them through `mxgraph.mxGraph`, `mxgraph.mxConstants`. This enables tree-shaking since bundlers can track individual named imports, improves readability by removing the repetitive `mxgraph.` prefix, and makes imports explicit about which mxGraph objects each module actually depends on. mxGraph is exported separately with an explicit `typeof` annotation to work around api-extractor losing constructor type information during .d.ts rollup, which caused TS2507 in downstream type checks.
|
🎊 PR Preview 24f045f has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3491.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
|
🎊 PR Preview 24f045f has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3491.surge.sh 🕐 Build time: 0.013s
🤖 By surge-preview |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destructure mxGraph objects from the mxgraph factory export so internal
code imports them directly (e.g.
mxGraph,mxConstants) rather thanaccessing them through
mxgraph.mxGraph,mxgraph.mxConstants.This enables tree-shaking since bundlers can track individual named
imports, improves readability by removing the repetitive
mxgraph.prefix, and makes imports explicit about which mxGraph objects each
module actually depends on.
mxGraph is exported separately with an explicit
typeofannotation towork around api-extractor losing constructor type information during
.d.ts rollup, which caused TS2507 in downstream type checks.