Skip to content

docs: restore nodejs_compat flag on Cloudflare deployment page - #8158

Open
liamiepops wants to merge 1 commit into
prisma:mainfrom
liamiepops:docs/restore-cloudflare-nodejs-compat
Open

docs: restore nodejs_compat flag on Cloudflare deployment page#8158
liamiepops wants to merge 1 commit into
prisma:mainfrom
liamiepops:docs/restore-cloudflare-nodejs-compat

Conversation

@liamiepops

@liamiepops liamiepops commented Aug 23, 2026

Copy link
Copy Markdown

The Cloudflare deployment page tells you to set node_compat = true in wrangler.toml. Cloudflare replaced that with the nodejs_compat compatibility flag, and the current Prisma guide at /guides/deployment/cloudflare-workers already uses the new form, so the two pages contradict each other.

This was already fixed. #7468 made the same change on 3 February. It was lost when #7479 migrated the docs to Fumadocs on 12 February: the fixed file was renamed into docs.v6, and the current v7 page came from a copy that still had the old text.

This PR restores those changes. The compatibility_date in the example is set to today rather than the February date.

I hit this running Prisma 7.9.1 under workerd with nodejs_compat set in wrangler.jsonc.

Three things to note:

  • The commit has no Linear reference. I can't create one as an external contributor.
  • The same text is still present in the v6 copy of the page. I left it alone since it's archived.
  • chore(): upload new docs #7479, which knocked this fix out, touched 3,630 files. Five commits touched apps/docs/content/ between chore(): clean up some docs content #7468 and chore(): upload new docs #7479. Four added new guides, which are unaffected. The fifth, DR-6829 DOCS: Update "seconds" to "milliseconds" for sql server file #7442, was a fix like this one, and it got lost in the merge too, so the SQL Server page reads "seconds" again instead of "milliseconds". I'm not sure what it should read though, the PostgreSQL and MySQL pages say seconds, so I'm not sure milliseconds was correct, or what the intention was there. Someone needs to untangle that one. I only checked apps/docs/content/, so I don't know whether anything outside the docs was affected.

Summary by CodeRabbit

  • Documentation
    • Updated PostgreSQL deployment instructions for Cloudflare.
    • Added a wrangler.jsonc configuration example using nodejs_compat and a compatibility date.
    • Removed outdated Cloudflare Pages workaround guidance.

@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

@liamiepops is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b896cdd2-78e0-43df-8811-221d8e2c422b

📥 Commits

Reviewing files that changed from the base of the PR and between a039577 and a03f30e.

📒 Files selected for processing (1)
  • apps/docs/content/docs/orm/prisma-client/deployment/edge/deploy-to-cloudflare.mdx

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The Cloudflare PostgreSQL deployment instructions now use wrangler.jsonc with nodejs_compat and a compatibility date. The previous wrangler.toml configuration and Cloudflare Pages workaround note were removed.

Changes

Cloudflare deployment documentation

Layer / File(s) Summary
Update Wrangler configuration instructions
apps/docs/content/docs/orm/prisma-client/deployment/edge/deploy-to-cloudflare.mdx
The instructions replace node_compat in wrangler.toml with nodejs_compat in wrangler.jsonc. The example includes a compatibility date and removes the Cloudflare Pages workaround note.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to a03f3

This is a localized documentation update restoring the current Cloudflare compatibility flag guidance, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the documentation change to restore the nodejs_compat flag for Cloudflare deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant