Prisma Next Post Merge Polish#8043
Open
nurul3101 wants to merge 5 commits into
Open
Conversation
… fundamentals reading-data: MongoDB where() also accepts MongoFieldFilter expressions (comparisons, .and()/.not(), MongoOrExpr.of), not the object form only; link to the reference filter section. writing-data: stop presenting .push() as plainly usable; the reference marks array operations as unverified. Point to a verified op instead and link to the field-operations reference section. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The general Tabs' TabsContent kept fumadocs' [&>figure:only-child]:-m-4 bleed, but unlike fumadocs (and the padded codetabs variant) its container has no padding to compensate, so a lone code block was pulled 1rem up over the PostgreSQL/MongoDB tab triggers on every tab= code fence. Replace the bleed with a snug mt-2/mb-0 so the code block sits below the tab row. Also remove two console.log calls that fired on every npm-tab interaction. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Convert pure-code <Tabs> blocks in contract-authoring to tab= fences (house convention; the one prose-bearing pair stays a component). - Fix db.sql.public.postTag -> post_tag in advanced-queries (mapped table names are snake_case) and align the accessor wording with the reference. - Correct the contract-artifact roots explanation to cover both the SQL table accessor (root key) and the ORM accessor (model name). - Rescope the TypeScript-builder relation-target claim: PG takes model objects, MongoDB takes type-checked model names. - Add badge: early-access to the fundamentals and contract-authoring pages (every other Prisma Next page carries it). - Use "contract" (not "schema") for the authored artifact in data-modeling/index and how-migrations-work. - Name the RUNTIME.ITERATOR_CONSUMED code in reading-data's streaming note. - Normalize create-prisma -> create-prisma@next across the section. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughThis PR updates Prisma Next docs across contract-authoring, data-modeling, fundamentals, middleware, migrations, guides, extensions, and reference pages, adding early-access badges, changing scaffold references to ChangesDocumentation updates for Prisma Next early access
Eclipse component cleanup
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
Contributor
🍈 Lychee Link Check Report266 links: ✅ All links are working!Full Statistics Table
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
- Rewrite the-migration-graph page around the real problem (branches merge,
every database must catch up): user-problem opening, "When this matters",
a terms glossary, an Alice/Bob phone+avatarUrl worked example, an explicit
"What happens when you run migrate" list, task-oriented command tables, a
"Common tasks" section before the agent prompts, a tip box, and
impact-framed early-access limitations. Drop clever phrasing.
- Replace question-style openers ("New to X? Start with...") with direct
phrasing across data-modeling and contract-authoring pages.
- Normalize every "Prompt your coding agent" section to link
[Prisma Next skills](/ai/tools/skills#available-skills-for-prisma-next).
- Break the ops.json operation paragraph in how-migrations-work into a
numbered precheck/execute/postcheck list plus a bulleted operation-class list.
- Remove em dashes from reference-page prose and headings.
All commands, flags, refs, and graph output verified against prisma-next
0.14.x. cspell and lint:links pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Pushed a writing-polish pass over the merged The migration graph page got the heaviest rework. It now opens with the real problem (you add Applied across the tree:
Validation: all graph output, ref/migrate commands, flags, reserved tokens ( |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/docs/content/docs/orm/next/migrations/the-migration-graph.mdx`:
- Around line 201-205: Update the “See also” cross-reference in the migration
graph doc so it matches the terminology used by the linked “How migrations work”
page. In the list item referencing How migrations work, replace the
“plan-review-apply loop” wording with the documented “plan, edit, apply, roll
back” loop, using the existing link text and the related headings in the
migrations docs as guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d3b9cd44-ddd8-433e-bb08-00718af2c370
📒 Files selected for processing (28)
apps/docs/content/docs/guides/next/frameworks/elysia.mdxapps/docs/content/docs/guides/next/frameworks/hono.mdxapps/docs/content/docs/guides/next/runtimes/bun.mdxapps/docs/content/docs/guides/next/runtimes/deno.mdxapps/docs/content/docs/orm/next/contract-authoring/capabilities.mdxapps/docs/content/docs/orm/next/contract-authoring/psl-syntax.mdxapps/docs/content/docs/orm/next/contract-authoring/the-contract-artifact.mdxapps/docs/content/docs/orm/next/contract-authoring/the-data-contract.mdxapps/docs/content/docs/orm/next/contract-authoring/typescript-schema-builder.mdxapps/docs/content/docs/orm/next/data-modeling/index.mdxapps/docs/content/docs/orm/next/data-modeling/mongodb.mdxapps/docs/content/docs/orm/next/data-modeling/relational-databases.mdxapps/docs/content/docs/orm/next/extensions/using-extensions.mdxapps/docs/content/docs/orm/next/fundamentals/advanced-queries.mdxapps/docs/content/docs/orm/next/fundamentals/reading-data.mdxapps/docs/content/docs/orm/next/fundamentals/relations-and-joins.mdxapps/docs/content/docs/orm/next/fundamentals/transactions.mdxapps/docs/content/docs/orm/next/fundamentals/writing-data.mdxapps/docs/content/docs/orm/next/middleware/authoring-custom-middleware.mdxapps/docs/content/docs/orm/next/middleware/how-middleware-works.mdxapps/docs/content/docs/orm/next/migrations/applying-a-migration.mdxapps/docs/content/docs/orm/next/migrations/generating-a-migration.mdxapps/docs/content/docs/orm/next/migrations/how-migrations-work.mdxapps/docs/content/docs/orm/next/migrations/the-migration-graph.mdxapps/docs/content/docs/orm/next/reference/orm-client.mdxapps/docs/content/docs/orm/next/reference/raw-queries.mdxapps/docs/content/docs/orm/next/reference/sql-query-builder.mdxapps/docs/content/docs/orm/next/reference/transactions-and-runtime.mdx
✅ Files skipped from review due to trivial changes (26)
- apps/docs/content/docs/orm/next/fundamentals/relations-and-joins.mdx
- apps/docs/content/docs/orm/next/extensions/using-extensions.mdx
- apps/docs/content/docs/guides/next/runtimes/deno.mdx
- apps/docs/content/docs/guides/next/frameworks/hono.mdx
- apps/docs/content/docs/orm/next/migrations/applying-a-migration.mdx
- apps/docs/content/docs/orm/next/contract-authoring/the-data-contract.mdx
- apps/docs/content/docs/orm/next/data-modeling/relational-databases.mdx
- apps/docs/content/docs/orm/next/middleware/authoring-custom-middleware.mdx
- apps/docs/content/docs/guides/next/runtimes/bun.mdx
- apps/docs/content/docs/orm/next/contract-authoring/capabilities.mdx
- apps/docs/content/docs/orm/next/data-modeling/mongodb.mdx
- apps/docs/content/docs/orm/next/reference/raw-queries.mdx
- apps/docs/content/docs/guides/next/frameworks/elysia.mdx
- apps/docs/content/docs/orm/next/migrations/generating-a-migration.mdx
- apps/docs/content/docs/orm/next/fundamentals/transactions.mdx
- apps/docs/content/docs/orm/next/data-modeling/index.mdx
- apps/docs/content/docs/orm/next/reference/transactions-and-runtime.mdx
- apps/docs/content/docs/orm/next/middleware/how-middleware-works.mdx
- apps/docs/content/docs/orm/next/migrations/how-migrations-work.mdx
- apps/docs/content/docs/orm/next/reference/sql-query-builder.mdx
- apps/docs/content/docs/orm/next/contract-authoring/the-contract-artifact.mdx
- apps/docs/content/docs/orm/next/fundamentals/writing-data.mdx
- apps/docs/content/docs/orm/next/contract-authoring/psl-syntax.mdx
- apps/docs/content/docs/orm/next/reference/orm-client.mdx
- apps/docs/content/docs/orm/next/contract-authoring/typescript-schema-builder.mdx
- apps/docs/content/docs/orm/next/fundamentals/advanced-queries.mdx
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/docs/content/docs/orm/next/fundamentals/reading-data.mdx
Comment on lines
201
to
205
| ## See also | ||
|
|
||
| - [How migrations work](/orm/next/migrations/how-migrations-work): the plan–review–apply loop | ||
| - [How migrations work](/orm/next/migrations/how-migrations-work): the plan-review-apply loop | ||
| - [Applying a migration](/orm/next/migrations/applying-a-migration): how the runner walks the graph | ||
| - [Rollbacks and recovery](/orm/next/migrations/rollbacks-and-recovery): backwards edges in practice |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Terminology drift: "plan-review-apply loop" vs. documented "plan, edit, apply, roll back" loop.
This page describes the linked How migrations work page's loop as "the plan-review-apply loop," but that page itself documents the core loop as "plan, edit, apply, roll back" (no "review" step, and it explicitly includes rollback). This cross-reference mismatch could confuse readers looking for a "review" step that doesn't exist as a named stage.
✏️ Proposed fix
-- [How migrations work](/orm/next/migrations/how-migrations-work): the plan-review-apply loop
+- [How migrations work](/orm/next/migrations/how-migrations-work): the plan-edit-apply-rollback loopBased on the relevant code snippet from apps/docs/content/docs/orm/next/migrations/how-migrations-work.mdx:227-245, which states "The core loop on this page (plan, edit, apply, roll back) works today and is exercised in the Prisma Next test suite."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ## See also | |
| - [How migrations work](/orm/next/migrations/how-migrations-work): the plan–review–apply loop | |
| - [How migrations work](/orm/next/migrations/how-migrations-work): the plan-review-apply loop | |
| - [Applying a migration](/orm/next/migrations/applying-a-migration): how the runner walks the graph | |
| - [Rollbacks and recovery](/orm/next/migrations/rollbacks-and-recovery): backwards edges in practice | |
| ## See also | |
| - [How migrations work](/orm/next/migrations/how-migrations-work): the plan-edit-apply-rollback loop | |
| - [Applying a migration](/orm/next/migrations/applying-a-migration): how the runner walks the graph | |
| - [Rollbacks and recovery](/orm/next/migrations/rollbacks-and-recovery): backwards edges in practice |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/docs/content/docs/orm/next/migrations/the-migration-graph.mdx` around
lines 201 - 205, Update the “See also” cross-reference in the migration graph
doc so it matches the terminology used by the linked “How migrations work” page.
In the list item referencing How migrations work, replace the “plan-review-apply
loop” wording with the documented “plan, edit, apply, roll back” loop, using the
existing link text and the related headings in the migrations docs as guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
create-prisma@nextand improved links to available Prisma Next skills..where(...)behavior notes and runtime error example details.