Skip to content

chore(drive): record the pinned deployment-logs HTTP contract - #189

Closed
wmadden-electric wants to merge 1 commit into
mainfrom
chore/unshelve-deployment-logs
Closed

chore(drive): record the pinned deployment-logs HTTP contract#189
wmadden-electric wants to merge 1 commit into
mainfrom
chore/unshelve-deployment-logs

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

Purpose of change

The platform endpoint for deployment logs shipped: prisma/pdp-control-plane#4886. This updates the S8 deferred entry (service logs) with the pinned contract so the follow-up slice can come off the shelf.

What's changed

  • .drive/projects/prisma-cli-v8/deferred.md: the R-S8-5 entry now records the merged contract — plain authenticated GET /v1/deployments/{deploymentId}/logs returns one NDJSON page (unchanged log/terminal record shapes) ending in a terminal record with a resume cursor; tail/from_start/cursor query params; WebSocket live tail unchanged on the same path; SDK exposure arrives with the next management-api production deploy.

🤖 Generated with Claude Code

The platform endpoint shipped (prisma/pdp-control-plane#4886): plain
GET returns one NDJSON page ending in a terminal record with a resume
cursor. Updates the S8 deferred entry so the service-logs follow-up
slice can start from the pinned contract.

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c2f71e07-a5f5-4198-95b4-27c0c6c3060b


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@189
npx https://pkg.pr.new/@prisma/cli-engine@189

commit: cff1915

@wmadden-electric

Copy link
Copy Markdown
Contributor Author

Deployed: the production management API now serves the paged contract (GET /v1/deployments/{deploymentId}/logs, 200 application/x-ndjson). The SDK regeneration was dispatched by the same deploy workflow. The service logs slice is fully unblocked.

@wmadden-electric

Copy link
Copy Markdown
Contributor Author

Redundant: #181 already implements service logs against this contract and carries the context. One useful fact from here: pdp-control-plane#4886 deployed to production today — the paged GET is live (verified against https://api.prisma.io/v1/doc).

@wmadden-electric
wmadden-electric deleted the chore/unshelve-deployment-logs branch August 17, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant