-
Notifications
You must be signed in to change notification settings - Fork 873
docs: add Northflank Prisma Postgres guide #7447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds documentation and a spelling entry: a new MDX guide describing how to deploy a Node.js app using Prisma/Postgres to Northflank (prereqs, build/runtime config, env vars, migration/run options, health checks, scaling, troubleshooting) and a cSpell addition for "Northflank". Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@content/250-postgres/350-integrations/700-northflank.mdx`:
- Line 142: The subheading string "Prisma schema not found or Client not
generated correctly" should be updated to sentence case and explicitly reference
the product name "Prisma Client"; replace that heading (the line containing "###
Prisma schema not found or Client not generated correctly") with "### Prisma
schema not found or Prisma Client not generated correctly" so the casing is
sentence case and the product name is preserved.
- Around line 95-115: Update the three option headings to sentence case: change
"Option 1: Use the Northflank CLI", "Option 2: Use command override", and
"Option 3: Use a Job" so only the first word and proper nouns remain capitalized
(e.g., keep "Northflank" and "CLI" capitalized but change "Job" to "job"); edit
the heading strings in the file where those exact headings appear (look for the
lines containing "Option 1:", "Option 2:", and "Option 3:") and apply
sentence-case formatting consistently.
dc27391 to
3787e6b
Compare
|
cc @ankur-arch Kindly check this out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@content/250-postgres/350-integrations/700-northflank.mdx`:
- Around line 95-99: The northflank CLI example for running Prisma migrations is
missing required flags and will fail; update the `northflank exec service`
invocation to include the project and service identifiers (use `--projectId` and
`--serviceId` or the short forms `--project` and `--service`) so the command
becomes e.g. `northflank exec service --project <project-id> --service
<service-id> --cmd "npx prisma migrate deploy"`; ensure this replacement is
applied to the block containing the `northflank exec service` example.
🧹 Nitpick comments (1)
content/250-postgres/350-integrations/700-northflank.mdx (1)
75-89: Clarify whenprisma.config.tsapplies (vsschema.prisma).
Some Prisma ORM projects won’t haveprisma.config.ts; a short note helps readers map the env var to their actual config file.📌 Suggested clarification
-Ensure that the data source in your `prisma.config.ts` file is configured to use the `DATABASE_URL` environment variable: +Ensure that the data source in your `prisma.config.ts` file is configured to use the `DATABASE_URL` environment variable. If your project doesn't use `prisma.config.ts`, make sure the datasource in `schema.prisma` uses `env("DATABASE_URL")` instead.
|
Thanks for putting up the PR, @AdeboyeDN! You’ll need to add |
Hi, this should be good to merge now |
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.