-
Notifications
You must be signed in to change notification settings - Fork 873
DR-6829 DOCS: Update "seconds" to "milliseconds" for sql server file #7442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying docs with
|
| Latest commit: |
8cff78a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0aae7605.docs-51g.pages.dev |
| Branch Preview URL: | https://dr-6829-time-duration-config.docs-51g.pages.dev |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
WalkthroughThe change updates SQL Server database configuration documentation to specify that multiple timeout parameters—connectTimeout, loginTimeout, connectionTimeout, socketTimeout, and poolTimeout—are measured in milliseconds rather than seconds. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Note: This is a straightforward documentation correction involving consistent unit conversions across related timeout parameters. The homogeneous nature of the changes—applying the same "seconds to milliseconds" update pattern across multiple field descriptions—minimizes cognitive overhead. A quick review confirms the parameter descriptions now align with the actual millisecond precision used by the SQL Server connector, eliminating potential confusion for developers configuring connection parameters. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/200-orm/050-overview/500-databases/800-sql-server/index.mdx (1)
141-142: Inconsistency: Warning box still uses seconds notation.The warning box references
15s,5s,30s, and300s—clearly indicating seconds. This conflicts with the parameter table above which now states these timeouts are in milliseconds.If the milliseconds change is correct, this warning should be updated to use milliseconds (e.g.,
15000msor15,000 milliseconds). If this warning is correct, then the parameter table changes may be incorrect.
🤖 Fix all issues with AI agents
In `@content/200-orm/050-overview/500-databases/800-sql-server/index.mdx`:
- Around line 127-132: The table lists connectTimeout and poolTimeout defaults
as 5 and 10 but mistakenly treats them as milliseconds; update the table so the
defaults reflect seconds: either change the values to 5000 and 10000 if you
intend milliseconds, or (preferred) keep numeric defaults as 5 and 10 and
correct the unit/description to "seconds" for the `connectTimeout` and
`poolTimeout` rows (and any related explanatory text) so it matches Prisma's
docs; ensure you update the `connectTimeout` and `poolTimeout` entries
accordingly.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.