Skip to content

Conversation

@ArthurGamby
Copy link
Contributor

@ArthurGamby ArthurGamby commented Jan 19, 2026

Summary by CodeRabbit

  • Documentation
    • Updated SQL Server timeout configuration documentation. All timeout-related parameters (connectTimeout, loginTimeout, connectionTimeout, socketTimeout, poolTimeout) now correctly reflect milliseconds as the unit of measurement instead of seconds.

✏️ Tip: You can customize this high-level summary in your review settings.

@cloudflare-workers-and-pages
Copy link

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8cff78a
Status: ✅  Deploy successful!
Preview URL: https://0aae7605.docs-51g.pages.dev
Branch Preview URL: https://dr-6829-time-duration-config.docs-51g.pages.dev

View logs

@github-actions
Copy link
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

Walkthrough

The change updates SQL Server database configuration documentation to specify that multiple timeout parameters—connectTimeout, loginTimeout, connectionTimeout, socketTimeout, and poolTimeout—are measured in milliseconds rather than seconds.

Changes

Cohort / File(s) Summary
SQL Server Timeout Unit Alignment
content/200-orm/050-overview/500-databases/800-sql-server/index.mdx
Updated timeout parameter descriptions from seconds to milliseconds across connectTimeout, loginTimeout, connectionTimeout, socketTimeout, and poolTimeout fields. Documentation now consistently specifies millisecond granularity for all timing configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Note: This is a straightforward documentation correction involving consistent unit conversions across related timeout parameters. The homogeneous nature of the changes—applying the same "seconds to milliseconds" update pattern across multiple field descriptions—minimizes cognitive overhead. A quick review confirms the parameter descriptions now align with the actual millisecond precision used by the SQL Server connector, eliminating potential confusion for developers configuring connection parameters.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating timeout field documentation from seconds to milliseconds in the SQL Server configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

@github-actions
Copy link
Contributor

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
content/200-orm/050-overview/500-databases/800-sql-server/index.mdx (1)

141-142: Inconsistency: Warning box still uses seconds notation.

The warning box references 15s, 5s, 30s, and 300s—clearly indicating seconds. This conflicts with the parameter table above which now states these timeouts are in milliseconds.

If the milliseconds change is correct, this warning should be updated to use milliseconds (e.g., 15000ms or 15,000 milliseconds). If this warning is correct, then the parameter table changes may be incorrect.

🤖 Fix all issues with AI agents
In `@content/200-orm/050-overview/500-databases/800-sql-server/index.mdx`:
- Around line 127-132: The table lists connectTimeout and poolTimeout defaults
as 5 and 10 but mistakenly treats them as milliseconds; update the table so the
defaults reflect seconds: either change the values to 5000 and 10000 if you
intend milliseconds, or (preferred) keep numeric defaults as 5 and 10 and
correct the unit/description to "seconds" for the `connectTimeout` and
`poolTimeout` rows (and any related explanatory text) so it matches Prisma's
docs; ensure you update the `connectTimeout` and `poolTimeout` entries
accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants